Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red spell check line is shown frequently in composer when typing #48662

Closed
puneetlath opened this issue Sep 5, 2024 · 8 comments
Closed

Red spell check line is shown frequently in composer when typing #48662

puneetlath opened this issue Sep 5, 2024 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@puneetlath
Copy link
Contributor

puneetlath commented Sep 5, 2024

When typing in the composer the red spell check line shows up very frequently. Much more frequently than in apps like Slack and Github. According to Michał Skałka the problem is likely with the Live Markdown element rendering. It happens too often and also every input value is taken as a final word immediately after typing any letter.

Let's look into that and fix it.

Screen.Recording.2024-09-04.at.3.53.24.PM.1.mov
Issue OwnerCurrent Issue Owner: @Skalakid
@puneetlath puneetlath added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 5, 2024
@puneetlath puneetlath self-assigned this Sep 5, 2024
Copy link

melvin-bot bot commented Sep 5, 2024

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

@Skalakid
Copy link
Contributor

Skalakid commented Sep 5, 2024

Hello, I'm Michał from SWM, and I will investigate this issue 😄

Copy link

melvin-bot bot commented Sep 9, 2024

@puneetlath, @Skalakid Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@puneetlath
Copy link
Contributor Author

@Skalakid do we just need to update the rn-live-markdown version in App now?

@Skalakid
Copy link
Contributor

Skalakid commented Sep 11, 2024

@puneetlath Hi, yes that's the last thing that we have to do. However, I see that there is already another PR that is bumping the LM version and it will contain my fixes for this issue. So I wrote the comment under the PR to include test steps for QAs

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2024
@puneetlath
Copy link
Contributor Author

Ah, great!

Copy link

melvin-bot bot commented Sep 16, 2024

@puneetlath, @Skalakid Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@puneetlath
Copy link
Contributor Author

Looks like #48626 is meged and on production. I also tested myself and it's feeling much better! Thanks for quick fix.

@melvin-bot melvin-bot bot removed the Overdue label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

2 participants