"Release options" modal ( CTRL+D) does not appear when image is open

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to any chat
2. Open a image from chat history
3. Press Ctrl+D to open "Release options" modal

Expected Result:

"Release options" modal should appear

Actual Result:

"Release options" modal ( CTRL+D) does not appear when image is open

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6622561_1727900232986.Recording__4213.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-10-03 00:58:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Modal ( CTRL+D) does not appear when image is open

What is the root cause of that problem?

We don't close the previous modals when we open Debug modal using shortcut key CMD + D

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 379 to 383 in b52f1d4

	const unsubscribeDebugShortcut = KeyboardShortcut.subscribe(
	debugShortcutConfig.shortcutKey,
	() => {
	toggleTestToolsModal();
	},

What changes do you think we should make in order to solve the problem?

We can use Modal.close here

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 379 to 383 in b52f1d4

	const unsubscribeDebugShortcut = KeyboardShortcut.subscribe(
	debugShortcutConfig.shortcutKey,
	() => {
	toggleTestToolsModal();
	},

We can do something like this Pseudo code

 const unsubscribeDebugShortcut = KeyboardShortcut.subscribe(
            debugShortcutConfig.shortcutKey,
            () => {
                  Modal.close(toggleTestToolsModal);
            },
            debugShortcutConfig.descriptionKey,
            debugShortcutConfig.modifiers,
            true,
        );

Screen.Recording.2024-10-03.at.5.54.02.AM.mov

This will also fix the modal issue in other parts of app

Before

Screen.Recording.2024-10-03.at.5.57.14.AM.mov

After

Screen.Recording.2024-10-03.at.5.54.23.AM.mov

What alternative solutions did you explore? (Optional)

Optionally we can also use Session.checkIfActionIsAllowed along with above solution

[bernhardoj]

Same solution as #49802

[alexpensify]

@bernhardoj do you think we should close this one or put it on hold for #49802

[bernhardoj]

Let's hold it for #49802