Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search v2.3] - Saved search list is not scrollable when there is a long list #50227

Open
2 of 6 tasks
IuliiaHerets opened this issue Oct 4, 2024 · 7 comments
Open
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • User has saved a long list of searches.
  1. Go to staging.new.expensify.com
  2. Go to Search.
  3. Scroll down the saved search list.

Expected Result:

The saved search list should be scrollable.

Actual Result:

The saved search list is not scrollable when there is a long list.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6624165_1728032604137.20241004_165905.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 4, 2024
Copy link

melvin-bot bot commented Oct 4, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-control

@IuliiaHerets
Copy link
Author

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@jayeshmangwani
Copy link
Contributor

jayeshmangwani commented Oct 4, 2024

This issue stems from the current PR and is still within the regression period. Wrapping SearchTypeMenu in Animated.View is causing the scroll to stop working.

cc: @SzymczakJ @rayane-djouah @luacmartins

@jayeshmangwani
Copy link
Contributor

Its in production #48258 (comment)

@rayane-djouah
Copy link
Contributor

PR is here: #50244
cc @SzymczakJ @luacmartins

@luacmartins luacmartins changed the title Saved search - Saved search list is not scrollable when there is a long list [Search v2.3] - Saved search list is not scrollable when there is a long list Oct 4, 2024
@luacmartins
Copy link
Contributor

Thanks.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Polish
Development

No branches or pull requests

6 participants