Chat - There is no closing question mark on delete comment confirmation modal in Spanish

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5045504
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Pre-requisite: the user must have set the language preference to Spanish.

1. Go to any chat.
2. Right click on any message (send a message is there is none).
3. Click on "Eliminar comentario".

Expected Result:

Text on confirmation modal should say: ¿Estás seguro de que quieres eliminar este comentario?

Actual Result:

Text on confirmation modal says: ¿Estás seguro de que quieres eliminar este comentario

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[MuaazArshad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - There is no closing question mark on delete comment confirmation modal in Spanish

What is the root cause of that problem?

We are not adding ? here

App/src/languages/es.ts

Line 636 in 99f280b

deleteConfirmation: ({action}: DeleteConfirmationParams) =>

What changes do you think we should make in order to solve the problem?

We should add it like this

deleteConfirmation: ({action}: DeleteConfirmationParams) =>
            `¿Estás seguro de que quieres eliminar este ${action?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? 'gasto?' : 'comentario?'}`,

What alternative solutions did you explore? (Optional)

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-10-05 15:54:14 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no closing question mark on delete comment confirmation modal in Spanish

What is the root cause of that problem?

this translation is not correct

App/src/languages/es.ts

Lines 636 to 637 in 87ea100

	deleteConfirmation: ({action}: DeleteConfirmationParams) =>
	`¿Estás seguro de que quieres eliminar este ${action?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? 'gasto' : 'comentario'}`,

What changes do you think we should make in order to solve the problem?

add question mark to the end

deleteConfirmation: ({action}: DeleteConfirmationParams) =>
            `¿Estás seguro de que quieres eliminar este ${action?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? 'gasto' : 'comentario'}?`,

What alternative solutions did you explore? (Optional)

[abzokhattab]

Proposal updated

Added the exact code changes