Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VetMassKillCredit over VetExperience in the UI when a unit reached maximum veterancy #6325

Open
Garanas opened this issue Jul 7, 2024 · 0 comments
Open

Use VetMassKillCredit over VetExperience in the UI when a unit reached maximum veterancy #6325

Garanas opened this issue Jul 7, 2024 · 0 comments
Labels
area: ui Anything to do with the User Interface of the Game good first issue issue that is relative easy to pick up

Comments

@Garanas
Copy link
Member

Garanas commented Jul 7, 2024 •
edited
Loading

Description

The field VetMassKillCredit is introduced by #6110 but it is not used yet. As a result the value will not show up to the user.

Course of Action

Extend unitview.lua to retrieve and use the unit statistic VetMassKillCredit when a unit has a veterancy level of 5 or higher. This should be a relative small change where VetLevel and VetExperience are already retrieved. When the value of VetLevel is 5 or more, instead of retrieving VetExperience you retrieve VetMassKillCredit.

Test Plan

Verify that the correct value is used when a unit switches from veterancy 4 to veterancy 5.
@Garanas Garanas added area: ui Anything to do with the User Interface of the Game good first issue issue that is relative easy to pick up labels Jul 7, 2024
printlnHello added a commit to printlnHello/fa that referenced this issue Aug 24, 2024
@printlnHello
[FAForever#6325] Show total mass killed on Vet 5
65cddcc 
Use VetMassKillCredit instead of regular VetExperience when the unit reached VetLevel 5 (or higher)
@BlackYps BlackYps removed this from the Development iteration III of 2024 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: ui Anything to do with the User Interface of the Game good first issue issue that is relative easy to pick up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Garanas @BlackYps