-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChangeType.update stac_dist/dominant_leaf_type_10m/dominant_leaf_type_10m.json #303
base: main
Are you sure you want to change the base?
Conversation
…pull request submission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor corrections needed. Most importantly, the extent does not look right. In EEA SDI spatial catalog is
...
<gmd:westBoundLongitude>
<gco:Decimal>-56.506</gco:Decimal>
</gmd:westBoundLongitude>
<gmd:eastBoundLongitude>
<gco:Decimal>72.907</gco:Decimal>
</gmd:eastBoundLongitude>
<gmd:southBoundLatitude>
<gco:Decimal>24.284</gco:Decimal>
</gmd:southBoundLatitude>
<gmd:northBoundLatitude>
<gco:Decimal>72.665</gco:Decimal>
...
The extent that you referenced is for a WGS84 bbox. But this data is in native CRS EPSG:3035, and has coordinates in metres and not degrees. |
But these
|
@mari-s4e I think you discovered a bug in the catalog-editor (cc @baloola). This WGS84 bbox was generated by the catalog-editor, I only entered the EPSG:3035 coordinates in it (the "x" and "y" in the json). Our WMS service also reports a WGS84 bbox which matches the one you showed in the previous comment:
|
This is not a bug, catalog editor reprojects the X & Y dimensions extnets to WGS84 and generates the bbox, according to stac item spec (same goes for the geometry as well) |
@baloola there is a bug because the generated northBoundLatitude is 58.95275109308057, but it should be 72.66. The problem is likely that you transform individual coordinates which is incorrect (cc @bangph for pointing this out). This can be verified with
It gives 58.952 like the catalog-editor and not 72.66. The correct way is to transform the whole bbox, e.g. with
<VRTDataset rasterXSize="650000" rasterYSize="460000">
<SRS>EPSG:3035</SRS>
<GeoTransform>900000, 10, 0, 5500000, 0, -10</GeoTransform>
<VRTRasterBand dataType="Byte" band="1">
<NoDataValue>0</NoDataValue>
<SimpleSource>
<SourceFilename relativeToVRT="1">dummy.tif</SourceFilename>
<SourceBand>1</SourceBand>
<SourceProperties RasterXSize="1" RasterYSize="1" DataType="Byte" BlockXSize="1" BlockYSize="1"/>
<SrcRect xOff="0" yOff="0" xSize="1" ySize="1"/>
<DstRect xOff="0" yOff="0" xSize="1" ySize="1"/>
</SimpleSource>
</VRTRasterBand>
</VRTDataset>
|
@mari-s4e FYI I created a separate issue for the bbox problem. I don't think it's practical that I go through some 30 jsons and fix these bboxes manually - I expect this to be fixed in the catalog separately, as it probably affects already published catalog entries as well. So I suggest to ignore the bbox in this and other reviews until that issue is solved. |
{"filename": "dominant_leaf_type_10m/dominant_leaf_type_10m.json", "item_type": "stac_dist", "change_type": "Update", "user": "FAiRICUBE", "data_owner": true}