Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

case format for type element in Choice Types #10

Open
niquola opened this issue Jan 13, 2019 · 3 comments
Open

case format for type element in Choice Types #10

niquola opened this issue Jan 13, 2019 · 3 comments

Comments

@niquola
Copy link
Member

niquola commented Jan 13, 2019

We represent choice types as records, the question is what case to use to name type-elements

  1. Observation.value.quantity - all elements in FHIR starts from lower
  2. Observation.value.Quantity - keep exact type name
@niquola
Copy link
Member Author

niquola commented Jan 13, 2019

in (1) we could not get exact type name just from element name, because we do not know was first letter of type name up or down

@niquola
Copy link
Member Author

niquola commented Jan 13, 2019

We need clarification in spec about this!
And fix example from https://github.com/rbrush/sql-on-fhir/blob/master/sql-on-fhir.md#extensions-duplicated-as-first-class-fields, which is lowercase

@rbrush
Copy link
Collaborator

rbrush commented Jan 17, 2019

I think the "least surprising behavior" for this is that all fields are lower camelCase, so it would be Observation.value.quantity. Thinking about the perspective of a user new to the system, I'd imagine they'd expect it to be lower case do I'd lean that way...but could be convinced otherwise if there is a compelling reason.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants