Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle configuration #962

Closed
z3db0y opened this issue Mar 23, 2024 · 6 comments
Closed

Gradle configuration #962

z3db0y opened this issue Mar 23, 2024 · 6 comments

Comments

@z3db0y
Copy link

z3db0y commented Mar 23, 2024

Hello, I'd like to propose a few changes towards the gradle configuration file:

  • compileSdkVersion is upgraded from 29 to 34
  • upgrade gradle (please)

The primary reason for this request is out of the box support for Kotlin, however keeping deps up to date is good practice in general. I could make a PR but I'm too lazy :P

@That-Madman
Copy link

I'd second that (though I'm quite late to the party). Out of the box Kotlin support would be nice, but what would be better is if the gradle config could be changed to not use deprecated features? I had half of my branches start refusing to build when I updated gradle.

@z3db0y
Copy link
Author

z3db0y commented Aug 30, 2024

Yea gradle is a pain in the ass 90% of the time; you have to align all the versions like stars to get your code to build 😅

@ofluffydev
Copy link

I made a PR with tons of fixes and updates including this one and got it instantly closed by a bot with a message saying "sorry we don't take prs" 😭

@texasdiaz
Copy link
Collaborator

That's because the FtcRobotController repository is the "output" of our internal build process, it's actually automatically generated. We cannot accept PRs to the repo because it cannot go backwards.

If you have suggestions for updates, you can send a link to your PR to [email protected] and we'll consider it.

-Danny

@ofluffydev
Copy link

Welp fix the build process to not use things that are years behind please?

@texasdiaz
Copy link
Collaborator

Welp fix the build process to not use things that are years behind please?

Comments like this are not helpful. A lot of things you depend on no longer work properly in newer versions of Gradle, and there are multitudes of build processes that you're not aware of that must be retrofitted because they also break in newer versions. Also, with the planned obsolescence of the FTC SDK build environment there's only so much work we're going to do - the ROI just doesn't make sense.

@FIRST-Tech-Challenge FIRST-Tech-Challenge locked and limited conversation to collaborators Sep 27, 2024
@texasdiaz texasdiaz closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants