Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache for stuff stored in instance storage #352

Open
FRosner opened this issue Feb 20, 2018 · 0 comments
Open

Use cache for stuff stored in instance storage #352

FRosner opened this issue Feb 20, 2018 · 0 comments
Milestone

Comments

@FRosner
Copy link
Owner

FRosner commented Feb 20, 2018

Problem

Right now we store nomad and consul information about instances in a hash map inside the InstanceService. This is a potential memory leak.

I don't think it's a severe risk as with the current code base we actually always overwrite the info coming from Nomad / Consul. So as long as nobody changes the code we should be fine.

Solution

Use the play cache API with an appropriate TTL (e.g. double the nomad refresh time).

@FRosner FRosner added this to the 0.8.0 milestone Feb 20, 2018
@FRosner FRosner modified the milestones: 0.8.0, 0.9.0 Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant