Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JS code more testable #203

Closed
FRosner opened this issue Jul 16, 2015 · 1 comment
Closed

Make JS code more testable #203

FRosner opened this issue Jul 16, 2015 · 1 comment
Assignees
@FRosner
Labels
Refactoring Wontfix
Milestone
Backlog

Comments

@FRosner
Copy link
Owner

FRosner commented Jul 16, 2015

When working on #106 I found that a lot of my code is actually not testable because it depends on global variables (document, window, etc.).

So I should try to refactor most of it to make it more modular and thus testable.
@FRosner FRosner self-assigned this Jul 16, 2015
@FRosner FRosner added this to the 2.4.0 milestone Jul 16, 2015
@FRosner FRosner modified the milestones: 2.4.0, 3.0.0 Aug 14, 2015
@FRosner
Copy link
Owner Author

FRosner commented Sep 2, 2015

Will be happening with #235 anyway, as I can test controllers and stuff individually.

@FRosner FRosner closed this as completed Sep 2, 2015
@FRosner FRosner modified the milestones: Backlog, 3.0.0 Sep 2, 2015
@FRosner FRosner added the Wontfix label Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FRosner FRosner

Labels
Refactoring Wontfix
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@FRosner