Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LInux Debian, super user authority #1194

Open
Calibos opened this issue Aug 12, 2024 · 6 comments
Open

LInux Debian, super user authority #1194

Calibos opened this issue Aug 12, 2024 · 6 comments
Assignees
Labels

Comments

@Calibos
Copy link

Calibos commented Aug 12, 2024

What Operating System

Linux (Debian)

Debug Code

dbg:HYF3b5yWjNs

Describe the bug

Sadly, I couldn't get your debug tool to run. When I start the launcher, it tries to run in Admin mode, pulls up a password dialogue box. If you do anything but allow it, it crashes, and begins cycling instances of itself ending, and restarting, several at a time. I can't close them in the system manager before they've stopped themselves and started another one, it cycles fast enough that there appear to be multiple instances running. The only way I can end the cycle is rebooting, or logging out. I'm not sure why the program needs admin mode, and I'm uncomfortable running it that way.

Steps to reproduce

Start the FTB launcher, deny it access to admin mode.

Expected behaviour

Start FTB app, program opens, launch minecraft instance

Screenshots

image

Additional information

No response

@Calibos Calibos added the bug Something isn't working label Aug 12, 2024
@FTBTeam FTBTeam deleted a comment from ftb-helper bot Aug 12, 2024
@klugemonkey
Copy link

IMHO, should probably allow disabling or disable altogether updates from within the client for .deb installs. The client should probably inform the user that an update is available, but let root update it outside the client since that is how they installed it in the first place.

@MichaelHillcox
Copy link
Member

IIRC, this is the only route for updating we have. Are you inferring users should only be informed of an update and told to source it themselves?

@MichaelHillcox
Copy link
Member

Sadly, I couldn't get your debug tool to run. When I start the launcher, it tries to run in Admin mode, pulls up a password dialogue box. If you do anything but allow it, it crashes, and begins cycling instances of itself ending, and restarting, several at a time. I can't close them in the system manager before they've stopped themselves and started another one, it cycles fast enough that there appear to be multiple instances running. The only way I can end the cycle is rebooting, or logging out. I'm not sure why the program needs admin mode, and I'm uncomfortable running it that way.

Yeah this is very weird. I've not seen this before myself... The app would not do anything bad in admin mode, you can see this from the code in this repo but I do agree it shouldn't need admin mode. I'm not 100% sure on how this can be fixed but I can look into it. It's likely a quirk with Electron

@klugemonkey
Copy link

IIRC, this is the only route for updating we have. Are you inferring users should only be informed of an update and told to source it themselves?

Yes, that's exactly what I'm saying. If an application is installed as a .deb and requires root to install, then you probably don't want to be provide a whole new means to install packages by prompting for root access on the user side, through an electon library to pkexec to update their .dpkg. Inform the user that there is an update that requires root access to update. Allow them to download the .deb and install with command line, since that's how they installed it in the first place.

If they want a GUI for their installs, consider supporting apt and package managers by creating a repository that can be added with a sources.list.d .list file which points at the package repository, as well as letting them download the repository public key for installation. This is how most packages are installed in linux. Then at least they won't have to download it manually, but just check for updates and upgrade.

Last thing I want as an admin, is to have an Electron App use a third party API to call pkexec (PolicyKit aka PwnKit), to prompt me for my root credentials.

@klugemonkey
Copy link

But i think the main issue is that it's automatically trying to upgrade, not even let the user initiate on their own or decide to handle manually. Nor can it be disabled.

@klugemonkey
Copy link

Changing it such that automatic updates would be an option switch, providing an upgrade button for those that want to handle from user, showing in the gui that there is an update available would be preferable to forcing upgrade at start with nonstandard installation methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants