Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with layered parchment mappings, some classes don't get their method parameters mapped #1086

Open
fayer3 opened this issue Apr 4, 2024 · 0 comments

Comments

@fayer3
Copy link

fayer3 commented Apr 4, 2024

not sure if that is the same issue as #559 , but when using layered mappings with mojang + parchment the methods in some classes don't get their mapped parameters.

some I noticed are the following

  • com.mojang.blaze3d.platform.GlStatemanager
  • com.mojang.blaze3d.systems.RenderSystem
  • com.mojang.blaze3d.platform.TextureUtil

from that it seems to happen with all classes that have the @DontObfuscate annotation

with just yarn, or layered with yarn they are mapped correctly with the yarn mappings

in the parchment mappings they should be mapped https://github.com/ParchmentMC/Parchment/blob/versions/1.20.x/data/com/mojang/blaze3d/platform/GlStateManager.mapping

mapping setup:

mappings loom.layered() {
	officialMojangMappings()
	parchment("org.parchmentmc.data:parchment-1.20.4:2024.02.25@zip")
}

using loom 1.6-SNAPSHOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant