Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Settings button crashes with latest Controllify and Reese's Sodium Options #921

Open
1 task done
SheaFoxx opened this issue Jan 7, 2025 · 1 comment
Open
1 task done
Labels
mod New Fabric mod to include on hold Mods that are waiting for something before inclusion remove Mods that could be removed replace Replaces an existing mod

Comments

@SheaFoxx
Copy link

SheaFoxx commented Jan 7, 2025

Original issue

Unknown

Why should it be in the modpack

I believe Controllify has always been part of the pack, I can't find any reference to it in any commits, issues, or pull requests, but maybe I'm wrong.

Why shouldn't it be in the modpack

Controllify has a mixin that conflicts with Reese's Sodium Options, which clicking the Video Settings button it crashes the game.

Additional details

Reese's Sodium Options and Controllify

Temporary removal/replacement until fixed

Confirm

  • This mod removal request was written in good faith, taking into consideration why the mod was added in the first place. This is not a mod replacement request - for that purpose I should use the normal mod request form.
@SheaFoxx SheaFoxx added mod New Fabric mod to include remove Mods that could be removed labels Jan 7, 2025
@Madis0
Copy link
Member

Madis0 commented Jan 7, 2025

As the OP of this topic wasn't clear:

  • This is not an issue in any of the currently released versions of the modpack.
  • This only affects Minecraft 1.21.1 version, and only if the modpack decides to update to Sodium 0.6+ there.

I did consider this, but alternatives to Controlify don't seem great right now (too big or not compatible with Steam Deck), luckily the developer said that this issue is already fixed, pending release.
Nonetheless, there is no specific time schedule of when it will be released and when (whether) will the modpack update with it.

@Madis0 Madis0 added replace Replaces an existing mod on hold Mods that are waiting for something before inclusion labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod New Fabric mod to include on hold Mods that are waiting for something before inclusion remove Mods that could be removed replace Replaces an existing mod
Projects
None yet
Development

No branches or pull requests

2 participants