Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the SoundHandle on BaseSoundComponent #7310

Open
Fortune117 opened this issue Jan 4, 2025 · 3 comments
Open

Expose the SoundHandle on BaseSoundComponent #7310

Fortune117 opened this issue Jan 4, 2025 · 3 comments
Labels
api design Opinions of nerds

Comments

@Fortune117
Copy link

What it is?

I want to be able to check certain properties on a sound currently playing on a SoundPointComponent, such as Amplitude, IsPlaying and IsFinished.

These properties are not currently accessible.

What should it be?

Either the sound handle should be exposed or those properties should have access points in the BaseSoundComponent class.

@Fortune117 Fortune117 added the api design Opinions of nerds label Jan 4, 2025
@github-project-automation github-project-automation bot moved this to To triage in s&box tracker Jan 4, 2025
@aylaylay
Copy link

aylaylay commented Jan 4, 2025

The goal is to not expose sound handle outside these classes

@Fortune117
Copy link
Author

Even if the sound handle shouldn't be exposed we should at least be able to read the amplitude and IsPlaying/IsFinished state of the sound component.

@aylaylay
Copy link

aylaylay commented Jan 4, 2025

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api design Opinions of nerds
Projects
Status: To triage
Development

No branches or pull requests

2 participants