Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Long-term] Firestorm pack collections #37

Closed
3vorp opened this issue Dec 20, 2023 · 4 comments · Fixed by #44
Closed

[Long-term] Firestorm pack collections #37

3vorp opened this issue Dec 20, 2023 · 4 comments · Fixed by #44
Assignees
Labels
difficulty hard enhancement New feature or request evolution not an issue, but a future evolution for next version normal priority

Comments

@3vorp
Copy link
Contributor

3vorp commented Dec 20, 2023

Currently, settings.json stores a bunch of information about various resource packs. I was thinking that consolidating all that stuff into a single packs collection would make a lot more sense, since it's already structured data with known keys (the submission pack interface is usable as-is, it's basically a collection within a collection as it stands).

Existing information that could be combined would include:

  • Raw GitHub urls (for texture URL construction, autopush, finding MCMETAs, etc)
  • Submission information
  • Pack colors, display names, and logo URLs (currently stored in various settings.json fields)
  • Pack resolution (for contribution interface, is this field even used anywhere?)

16x packs could be stored in addition to Faithful packs here by simply having a boolean flag to enable submissions for a given listed pack. This way, one could support an arbitrary number of packs simply by registering a new one in the packs collection and modifying a few TypeScript interfaces.

@3vorp 3vorp added enhancement New feature or request normal priority difficulty hard evolution not an issue, but a future evolution for next version labels Dec 20, 2023
@3vorp 3vorp self-assigned this Dec 20, 2023
@3vorp
Copy link
Contributor Author

3vorp commented Dec 26, 2023

After a lot more thinking, I've decided this can function as three separate JSON files, much like how textures work.

packs.json would simply have basic information about each pack — GitHub urls, display names, pack tags, etc
submissions.json would have submission-related information, using a similar interface to the current submission setup in settings.json
projects.json (no idea what to call this) would have the syntax specified in #40

@3vorp 3vorp changed the title [Long-term] Firestorm pack collection [Long-term] Firestorm pack collections Dec 26, 2023
@3vorp 3vorp pinned this issue Dec 26, 2023
@TheRolfFR
Copy link
Member

Like this, projects.json to be defined

@3vorp
Copy link
Contributor Author

3vorp commented Dec 27, 2023

Cool, my thinking with having submissions.json separately stored is that the submission bot would have minimal breaking changes since the interface wouldn't change.

@3vorp
Copy link
Contributor Author

3vorp commented Jan 9, 2024

Decided to simplify my life and move projects.json into the actual texture db itself, see #39 for more info on that

@3vorp 3vorp linked a pull request Jan 15, 2024 that will close this issue
@3vorp 3vorp closed this as completed in #44 Jan 16, 2024
@3vorp 3vorp unpinned this issue Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty hard enhancement New feature or request evolution not an issue, but a future evolution for next version normal priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants