Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkillModifier doesnt work if you have more than 1 slot used in wearable #15338

Open
2 tasks done
Regalis11 opened this issue Dec 11, 2024 Discussed in #15331 · 1 comment
Open
2 tasks done

SkillModifier doesnt work if you have more than 1 slot used in wearable #15338

Regalis11 opened this issue Dec 11, 2024 Discussed in #15331 · 1 comment
Assignees
@Regalis11
Labels
Bug Something isn't working Code Programming task Ticket The issue has been converted into an issue report. Unstable Tickets that are included and being tested in the current Unstable build.

Comments

@Regalis11
Copy link
Collaborator

Discussed in #15331

Originally posted by PanmanS December 10, 2024

Disclaimers

  • I have searched the issue tracker to check if the issue has already been reported.
  • My issue happened while using mods.

What happened?

  1. 1 wearable slot
    image

  2. 2 slots in wearable
    image

	  <Item name="" identifier="divingsuit" category="Diving,Equipment" tags="diving,deepdiving,human" scale="0.5" fireproof="true" description="" allowdroppingonswapwith="diving" impactsoundtag="impact_metal_heavy" botpriority="1" cargocontaineridentifier="">
    <Price baseprice="250">
      <Price storeidentifier="merchantoutpost" multiplier="0.9" minavailable="2" />
      <Price storeidentifier="merchantcity" multiplier="0.85" minavailable="4" />
      <Price storeidentifier="merchantresearch" minavailable="3" />
      <Price storeidentifier="merchantmilitary" minavailable="3" />
      <Price storeidentifier="merchantmine" multiplier="1.25" minavailable="5" />
    </Price>
    <PreferredContainer primary="divingsuitcontainer" spawnprobability="1" campaignonly="true" maxleveldifficulty="35" />
    <PreferredContainer primary="divingsuitcontainer" spawnprobability="1" notcampaign="true" />
    <PreferredContainer primary="piratedivingsuitcontainer" spawnprobability="1" maxleveldifficulty="35" />
    <PreferredContainer primary="wreckdivingsuitcontainer" spawnprobability="0.1" maxleveldifficulty="35" />
    <Deconstruct time="30">
      <Item identifier="titaniumaluminiumalloy" />
      <Item identifier="rubber" />
    </Deconstruct>
    <Fabricate suitablefabricators="fabricator" requiredtime="30">
      <RequiredSkill identifier="mechanical" level="40" />
      <RequiredItem identifier="titaniumaluminiumalloy" />
      <RequiredItem identifier="rubber" />
      <RequiredItem identifier="rubber" />
    </Fabricate>
    <InventoryIcon texture="Content/Items/InventoryIconAtlas2.png" sourcerect="0,256,128,128" origin="0.5,0.5" />
    <!--
    <Sprite name="Diving Suit" texture="DivingSuit_Item.png" sourcerect="157,0,90,307" depth="0.55" origin="0.4888889,0.5439739" />
    -->
    <Sprite name="Diving Suit Item" texture="Content/Items/Diving/DivingSuit_Item.png" sourcerect="0,0,146,120" depth="0.55" origin="0.5,0.5" />
    <ContainedSprite name="Diving Suit In Vertical Locker" allowedcontainertags="divingsuitcontainervertical" texture="Content/Items/Diving/DivingSuit_Item.png" sourcerect="181,0,75,193" depth="0.55" origin="0.5,0.5" />
    <ContainedSprite name="Diving Suit Behind Window" allowedcontainertags="divingsuitcontainerwindow" texture="Content/Items/Containers/containers.png" sourcerect="724,373,77,209" depth="0.55" origin="-0.12,-0.14" />
    <ContainedSprite name="Diving Suit In Horizontal Locker" allowedcontainertags="divingsuitcontainerhorizontal" texture="Content/Items/Diving/DivingSuit_Item.png" sourcerect="0,193,230,63" depth="0.55" origin="0.6,0.5" />
    <Body radius="45" width="34" density="20" />
    <Wearable slots="OuterClothes+Head" msg="ItemMsgEquipSelect" displaycontainedstatus="true" canbeselected="false" canbepicked="true" pickkey="Select">
      <sprite name="Diving Suit Helmet Wearable" texture="Content/Items/Jobgear/headgears.png" limb="Head" inheritlimbdepth="true" inheritscale="true" ignorelimbscale="true" scale="0.65" hidelimb="false" alphaclipotherwearables="true" sourcerect="5,4,92,94" origin="0.5,0.5">
        <LightComponent range="200.0" lightcolor="250,224,165,255" powerconsumption="10" IsOn="true" allowingameediting="false">
          <Upgrade gameversion="0.1300.0.3" allowingameediting="false" />
          <StatusEffect type="OnWearing" target="This,Character" Voltage="1.0" Interval="0.1" setvalue="true">
            <Conditional IsDead="false" />
          </StatusEffect>
          <LightTexture texture="Content/Lights/divinghelmetlight.png" origin="0.05, 0.5" size="1.0,1.0" />
        </LightComponent>
      </sprite>
      <sprite name="Regular Diving Suit Torso" texture="Content/Items/Diving/reg_DivingSuit.png" limb="Torso" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Right Hand" texture="Content/Items/Diving/reg_DivingSuit.png" limb="RightHand" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Left Hand" texture="Content/Items/Diving/reg_DivingSuit.png" limb="LeftHand" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Right Upper Arm" texture="Content/Items/Diving/reg_DivingSuit.png" limb="RightArm" depthlimb="RightForearm" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Left Upper Arm" texture="Content/Items/Diving/reg_DivingSuit.png" limb="LeftArm" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Right Lower Arm" texture="Content/Items/Diving/reg_DivingSuit.png" limb="RightForearm" depthlimb="RightArm" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Left Lower Arm" texture="Content/Items/Diving/reg_DivingSuit.png" limb="LeftForearm" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Waist" texture="Content/Items/Diving/reg_DivingSuit.png" limb="Waist" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Right Thigh" texture="Content/Items/Diving/reg_DivingSuit.png" limb="RightThigh" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Left Thigh" texture="Content/Items/Diving/reg_DivingSuit.png" limb="LeftThigh" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Right Leg" texture="Content/Items/Diving/reg_DivingSuit.png" limb="RightLeg" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Left Leg" texture="Content/Items/Diving/reg_DivingSuit.png" limb="LeftLeg" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Left Shoe" texture="Content/Items/Diving/reg_DivingSuit.png" limb="LeftFoot" sound="footstep_armor_heavy" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <sprite name="Regular Diving Suit Right Shoe" texture="Content/Items/Diving/reg_DivingSuit.png" limb="RightFoot" sound="footstep_armor_heavy" hidelimb="true" inherittexturescale="true" hideotherwearables="true" inheritorigin="true" inheritsourcerect="true" />
      <StatusEffect type="OnWearing" target="Character" OxygenAvailable="-100.0" UseHullOxygen="false" />
      <StatusEffect type="OnWearing" target="Character" ObstructVisionAmount="0.5" PressureProtection="4000.0" LowPassMultiplier="0.2" setvalue="true" disabledeltatime="true">
        <Sound file="Content/Items/Diving/DivingSuitLoop1.ogg" range="250" loop="true"/>
        <Sound file="Content/Items/Diving/DivingSuitLoop2.ogg" range="250" loop="true"/>
        <TriggerAnimation Type="Walk" FileName="HumanWalkDivingSuit" priority="1" ExpectedSpecies="Human" />
        <!-- high prio for run animation so e.g. affliction-based run animations won't make the character run faster -->
        <TriggerAnimation Type="Run" FileName="HumanRunDivingSuit" priority="10" ExpectedSpecies="Human" />
      </StatusEffect>
      <!-- Refill oxygen when the suit is contained. -->
      <StatusEffect type="OnContained" target="Contained" Condition="1.0" interval="1" disabledeltatime="true">
        <Conditional Voltage="gt 0.01" TargetContainer="true" TargetGrandparent="true" targetitemcomponent="Powered" />
        <RequiredItem items="refillableoxygensource" type="Contained" excludebroken="false" excludefullcondition="true" />
      </StatusEffect>
      <damagemodifier armorsector="0.0,360.0" afflictionidentifiers="blunttrauma,gunshotwound,bitewounds,lacerations,bleeding,explosiondamage" damagemultiplier="0.9" damagesound="LimbArmor" deflectprojectiles="true" />
      <damagemodifier armorsector="0.0,360.0" afflictiontypes="burn" damagemultiplier="0.75" damagesound="" deflectprojectiles="true" />
      <damagemodifier armorsector="0.0,360.0" afflictionidentifiers="radiationsickness" damagemultiplier="0.75" damagesound="LimbArmor"/>
      <damagemodifier armorsector="0.0,360.0" afflictionidentifiers="huskinfection" probabilitymultiplier="0.5" damagesound="LimbArmor"/>
      <SkillModifier skillidentifier="weapons" skillvalue="20"/>
	</Wearable>
    <Holdable slots="RightHand+LeftHand" controlpose="true" holdpos="0,-50" handle1="-10,-20" handle2="10,-20" holdangle="45" msg="ItemMsgPickUpUse" canbeselected="false" canbepicked="true" pickkey="Use">
      <Upgrade gameversion="0.1401.0.0" msg="ItemMsgPickUpUse" />
    </Holdable>
    <ItemContainer capacity="1" maxstacksize="1" hideitems="true" containedstateindicatorstyle="tank">
      <SlotIcon slotindex="0" texture="Content/UI/StatusMonitorUI.png" sourcerect="64,448,64,64" origin="0.5,0.5" />
      <Containable items="oxygensource,weldingtoolfuel" excludeditems="oxygenitetank" />
      <Containable items="oxygensource">
        <StatusEffect type="OnWearing" target="Character" OxygenAvailable="1000.0" />
        <StatusEffect type="OnWearing" target="Contained" Condition="-0.3" comparison="And">
          <Conditional TargetContainer="true" TargetGrandparent="true" IsDead="false" />
          <Conditional TargetContainer="true" TargetGrandparent="true" DecreasedOxygenConsumption="lt 99" />
          <Conditional TargetContainer="true" TargetGrandparent="true" NeedsAir="true" />
        </StatusEffect>
        <StatusEffect type="OnWearing" target="Contained">
          <Conditional condition="lt 5.0" />
          <Sound file="Content/Items/WarningBeepSlow.ogg" range="250" loop="true"/>
        </StatusEffect>
      </Containable>
      <Containable items="oxygenitetank">
        <StatusEffect type="OnWearing" target="Character" SpeedMultiplier="1.2" setvalue="true" targetslot="0" comparison="And">
          <Conditional IsDead="false" />
          <Conditional DecreasedOxygenConsumption="lt 99" />
          <Conditional NeedsAir="true" />
        </StatusEffect>
      </Containable>
      <Containable items="weldingfueltank" blameequipperfordeath="true">
        <StatusEffect type="OnWearing" target="Contained" Condition="-0.5" comparison="And">
          <Conditional TargetContainer="true" TargetGrandparent="true" IsDead="false" />
          <Conditional TargetContainer="true" TargetGrandparent="true" DecreasedOxygenConsumption="lt 99" />
          <Conditional TargetContainer="true" TargetGrandparent="true" NeedsAir="true" />
        </StatusEffect>
        <StatusEffect type="OnWearing" target="Character" OxygenAvailable="-100.0" Oxygen="-5.0" comparison="And">
          <Conditional IsDead="false" />
          <Conditional DecreasedOxygenConsumption="lt 99" />
          <Conditional NeedsAir="true" />
        </StatusEffect>
      </Containable>
      <Containable items="incendiumfueltank" blameequipperfordeath="true">
        <StatusEffect type="OnWearing" target="Contained" Condition="-0.5" comparison="And">
          <Conditional TargetContainer="true" TargetGrandparent="true" IsDead="false" />
          <Conditional TargetContainer="true" TargetGrandparent="true" DecreasedOxygenConsumption="lt 99" />
          <Conditional TargetContainer="true" TargetGrandparent="true" NeedsAir="true" />
        </StatusEffect>
        <StatusEffect type="OnWearing" target="Character" OxygenAvailable="-100.0" comparison="And" targetlimb="Torso">
          <Affliction identifier="burn" amount="20.0"  />
          <Conditional IsDead="false" />
          <Conditional DecreasedOxygenConsumption="lt 99" />
          <Conditional NeedsAir="true" />
        </StatusEffect>
      </Containable>
      <StatusEffect type="OnWearing" target="Contained" playsoundonrequireditemfailure="true">
        <RequiredItem items="oxygensource" type="Contained" matchonempty="true" />
        <Conditional condition="lte 0.0" />
        <Sound file="Content/Items/WarningBeep.ogg" range="250" loop="true"/>
      </StatusEffect>
    </ItemContainer>
    <aitarget maxsightrange="1500" />  
  </Item>

Reproduction steps

  1. use code provided above for testing
  2. test in sub editor with 1 slot and 2 slots

Bug prevalence

Happens every time I play

Single player or multiplayer?

Single player

-

No response

Version

v1.6.19.1 (Unto the Breach Update Hotfix 2)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response
@Regalis11 Regalis11 added Bug Something isn't working Code Programming task Ticket The issue has been converted into an issue report. labels Dec 11, 2024
@Regalis11 Regalis11 self-assigned this Dec 11, 2024
@Regalis11
Copy link
Collaborator Author

Fixed in https://github.com/FakeFishGames/Barotrauma-development/commit/19ac21365bcdcee96965abdd140a1c398c05fb04

@Regalis11 Regalis11 added the Unstable Tickets that are included and being tested in the current Unstable build. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Regalis11 Regalis11

Labels
Bug Something isn't working Code Programming task Ticket The issue has been converted into an issue report. Unstable Tickets that are included and being tested in the current Unstable build.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Regalis11