Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication with Emby Connect #749

Open
1 task done
sgtcoder opened this issue May 14, 2024 · 15 comments · May be fixed by #943
Open
1 task done

Add authentication with Emby Connect #749

sgtcoder opened this issue May 14, 2024 · 15 comments · May be fixed by #943
Labels
enhancement New feature or request

Comments

@sgtcoder
Copy link

Description

It would be nice to be able to login with the Emby Connect email address vs having to login with your first name and last name. Seems a bit silly

Desired Behavior

Allow login with the Emby Connect email address rather than your first name and last name.

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@Fallenbagel
Copy link
Owner

Fallenbagel commented May 14, 2024

We only use username/password logins, which is the default authentication method for emby (without using the emby connect)

@sgtcoder
Copy link
Author

You mean the first name and last name is the username.

@Fallenbagel
Copy link
Owner

Fallenbagel commented May 14, 2024

You mean the first name and last name is the username.

No. I mean we specifically use username. It's emby that sets the first name/last name as username. We don't do that.

@sgtcoder
Copy link
Author

Understandable, that's a bit odd on Emby's part.

Anyway we can use the email address as well? Everyone is a bit confused on the name for the username.

@dmike3
Copy link

dmike3 commented May 14, 2024

Email logins via Emby connect users have been working for well over a year. All of a sudden they have stopped working and now users have to use their actual usernames now?

Did something change ?

@Fallenbagel
Copy link
Owner

Fallenbagel commented May 14, 2024

Email logins via Emby connect users have been working for well over a year. All of a sudden they have stopped working and now users have to use their actual usernames now?

Did something change ?

Nothing changed. We always supported username. we dont even provide support for emby connect. Never did.

If you are still sure it used to work on jellyseerr, you could whip up a new container instance and use a previous version and check

@sgtcoder
Copy link
Author

sgtcoder commented May 27, 2024

@Fallenbagel

This is not true. I just did a POST login through /emby/Users/AuthenticateByName and it supports both name and email. The same request you make through Jellyseerr as I saw in the logs.

Username
PW

@Fallenbagel
Copy link
Owner

Fallenbagel commented May 27, 2024

@Fallenbagel

This is not true. I just did a POST login through /emby/Users/AuthenticateByName and it supports both name and email. The same request you make through Jellyserr as I saw in the logs.

Username
PW

Nothing changed on our side is what I'm saying. We never used emails. Especially not emby connect. Jellyseerr was designed for jellyfin first, and emby was a happy accident.

So it is EMBY who sets the first name last name as the username when connected through emby connect. Not us. All we do is authenticate using whatever username is available through emby

@sgtcoder
Copy link
Author

Well the API call you use to connect to the Emby server, supports the name and username/email.

It is NOT Emby's issue. I literally just connected through their API and validated a response with email and/or NAME.

curl --location 'https://EMBY_SERVER/emby/Users/AuthenticateByName' \
--header 'Content-Type: application/json' \
--header 'X-Emby-Authorization: ••••••' \
--data-raw '{
    "Username":"EMBY_CONNECT_EMAIL",
    "PW":"PASSWORD_HERE"
}'

@Fallenbagel
Copy link
Owner

Fallenbagel commented May 27, 2024

Well the API call you use to connect to the Emby server, supports the name and username/email.

It is NOT Emby's issue. I literally just connected through their API and validated a response with email and/or NAME.

curl --location 'https://EMBY_SERVER/emby/Users/AuthenticateByName' \
--header 'Content-Type: application/json' \
--header 'X-Emby-Authorization: ••••••' \
--data-raw '{
    "Username":"EMBY_CONNECT_EMAIL",
    "PW":"PASSWORD_HERE"
}'

You're still not understanding what I'm saying. We never USED emails. We always USED usernames. It is not our fault that they CHOSE to set the first name and last name as the username when setup using emby connect.

We cannot support emby connect until this is merged #685

@Fallenbagel
Copy link
Owner

Fallenbagel commented May 27, 2024

@sgtcoder I am moving the discussion here.

We weren't claiming its an emby issue. Youre still misunderstanding the entire thing.

We NEVER USED emails. We have always USED usernames. We cannot SUPPORT emails until we refactor jellyseerr.

Your original query was that it's silly that we were using first name last name as a username. Thats not something we decided. That's the username that emby connect sets up afaik when using emby connect. We never said that it was an "issue" that emby "doesn't" support.

It was about your original query that we use first name last name as a username which was silly.

@Fallenbagel
Copy link
Owner

Fallenbagel commented May 27, 2024

I never claimed emby doesn't support email authentication. WE DONT. Because WE don't support emby per se either. The support is a happy accident through jellyfin api. Until we can refactor to decouple jellyfin and emby which is literally achieved by #685 that i linked, which you chose to ignore.

And your original post said that it's silly that we set the first name and last name as a username. We don't set that. Emby sets that. We only support username for emby for now. And it's not us setting the first name last name as the username.

@sgtcoder
Copy link
Author

Yes, I understand that now. And you literally just linked it and I responded back to it: #685 (comment)

Thank you for the clarification now. I think it could have been summarized as:

We currently don't support Emby Connect Email addresses, but we have a future update that should handle that. #685

Rather than

So it is EMBY'S issue that they set the first name last name as the username when connected through emby connect. Not > ours. All we do is authenticate using whatever username is available through emby

@Fallenbagel
Copy link
Owner

Fallenbagel commented May 27, 2024

Yes, I understand that now. And you literally just linked it and I responded back to it: #685 (comment)

Thank you for the clarification now. I think it could have been summarized as:

We currently don't support Emby Connect Email addresses, but we have a future update that should handle that. #685

Rather than

So it is EMBY'S issue that they set the first name last name as the username when connected through emby connect. Not > ours. All we do is authenticate using whatever username is available through emby

Your first query was "it's silly that we use first name last name as the username". We don't. We use emby's username. Which is the first name last name when connected through emby connect. It maybe silly but it's not something that we set. We don't make emby usernames.

having to login with your first name and last name. Seems a bit silly

@sgtcoder
Copy link
Author

sgtcoder commented May 27, 2024

It is true that it is silly that the First Name and Last Name is used as the username. But after reviewing, that seems to come through the Emby side.

However, there is the Emby Connect Email address that would also work on AuthenticateByName API call. I realize now that there are currently some limitations on Jellyseerr regarding that and there is an open PR that should hopefully address that.

Thank you for the hard work and the support for Emby.

Again, let me know in anyway I can be of help, whether it is testing or reviewing.

pXius added a commit to pXius/jellyseerr that referenced this issue Aug 24, 2024
Created an Emby Connect API with the required methods to orchestrate a set of calls towards
EmbyConnect to build a JellyseerrLoginResponse object. Added an EmbyConnect authentication call to
the Jellyfin login() method as the last authentication attempt, but only if the username is an email
address. Updated the post() method on the ExternalApi class to handle request bodies that need to be
x-www-form-urlencoded.

Fallenbagel#749
@pXius pXius linked a pull request Aug 24, 2024 that will close this issue
3 tasks
@gauthier-th gauthier-th changed the title Unable to login with Emby Connect email address Add authentication with Emby Connect Sep 15, 2024
@gauthier-th gauthier-th added the enhancement New feature or request label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants