Should we skip the User-Agent header?

[FantasticFiasco]

Describe the bug

As described a review remark of #1207, let's analyze if we should skip the User-Agent header instead having special support for it in the codebase (#1155).

[mungojam]

I wouldn't call it a workaround, it was changing it to implement the user agent spec. But if it can be skipped altogether in the signature then that's a good result

[FantasticFiasco]

You are correct, my intention was not to downplay this contribution. Bad wording on my part, I'll update my text.

[FantasticFiasco]

As it currently is worded, do you think it makes more sense, or can it be improved?

[mungojam]

As it currently is worded, do you think it makes more sense, or can it be improved?

It's all good now thanks 🙂

[cfbao]

I found one case where it makes sense to skip the user-agent header:
If a user of this library adds an empty string as the user-agent header (not implausible in a proxy server implementation that calls TryAddWithoutValidation on almost all headers), and sends the signed request to API Gateway, AWS will change the user-agent header to "Amazon CloudFront", and then the signature will be invalid.