Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False negative in Golomb compressed set 2 (test directory) #19

Open
richardstartin opened this issue Dec 27, 2019 · 2 comments
Open

False negative in Golomb compressed set 2 (test directory) #19

richardstartin opened this issue Dec 27, 2019 · 2 comments

Comments

@richardstartin
Copy link
Collaborator

richardstartin commented Dec 27, 2019 •
edited
Loading

Steps to reproduce:

Hash.setSeed(-2130647756636796307L);
long[] keys = new long[] {1, 2, 3};
int bitsPerKey = 8;
var filter = GCS2.construct(keys, bitsPerKey);
assertTrue(filter.mayContain(1)); // false
@thomasmueller
Copy link
Contributor

I temporarily disabled the test, will try to work on this next year.

@thomasmueller
Copy link
Contributor

Moved the implementation to the test directory. I think the bug is in BitBufferDirect.

@thomasmueller thomasmueller changed the title False negative in Golomb compressed set 2 False negative in Golomb compressed set 2 (test directory) Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasmueller @richardstartin