This repository has been archived by the owner on Jan 22, 2019. It is now read-only.
Bug in boundary checking in the CBORParser #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading from an composite inputStream, there's a bug during the checking of the buffer boundary. This may lead to an ArrayIndexOutOfBoundsException. I build a test case that expose the bug and fixed the bound checking.
|
Hey @cowtowncoder, did you have the chance to look at this PR? (no rush) |
|
Ah. Thank you for reminding! This did slip through, I did see original creation, but forgot to follow up. |
cowtowncoder
added a commit
that referenced
this pull request
Aug 19, 2015
Bug in boundary checking in the CBORParser
cowtowncoder
added a commit
that referenced
this pull request
Aug 19, 2015
cowtowncoder
added a commit
that referenced
this pull request
Aug 19, 2015
|
Big thank you for finding and fixing this problem. I verified and it is a regression from 2.5, related to symbol table changes and performance optimizations; so it does not affect pre-2.6 versions. |
|
I can work with the snapshot version in the meantime. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading from an composite inputStream, there's a bug during the checking
of the buffer boundary. This may lead to an ArrayIndexOutOfBoundsException.
I build a test case that expose the bug and fixed the bound checking.