Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Json[De]Serializer" -> "Value[De]Serializer" in 3.0 #500

Closed
cowtowncoder opened this issue Feb 9, 2021 · 4 comments
Closed

"Json[De]Serializer" -> "Value[De]Serializer" in 3.0 #500

cowtowncoder opened this issue Feb 9, 2021 · 4 comments
Assignees

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Feb 9, 2021

Ok, so as per FasterXML/jackson-databind#3044 I changed Scala module as well (with just mechanical search-and-replace), in master.

But it looks like I cannot re-compile with sbt for some reason. I suspect it might be due to some caching issue, but just in case I'll create this issue for someone else to have a look.
Hopefully it is just my system and this may be closed.

@pjfanning
Copy link
Member

@cowtowncoder
Copy link
Member Author

cowtowncoder commented Feb 9, 2021

Now I need to see what's up with local sbt but glad it's just some local issue. I did remove ivy cache (not sure that's used), tried sbt cleanFiles etc. But no doubt there's something like "sbt mrclean" or something :)

Of remaining rename work, as per:

https://github.com/FasterXML/jackson-future-ideas/wiki/JSTEP-6

I'll probably do SerializerProvider -> SerializationContext quite soon (and should be mechanical on Scala side so I can take care of it). Still thinking about details of JsonParser/JsonGenerator change, that'd go after it.. and then major changes would be complete wrt class names.
In semi-near future there's the package name change which will be pain but I'll send more notes on mailing list before that: while just mechanical changes (com.fasterxml.jackson -> com.fasterxml.jackson3), it affects literally everything.

@pjfanning
Copy link
Member

sbt clean update

-- this cleans build dir and updates the jar dependencies (useful when you have dependencies on snapshot jars)

@cowtowncoder
Copy link
Member Author

Hmmh. I thought I tried "sbt update" too but... either I was hallucinating, or it has to be with "clean" as well.
Regardless, good to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants