Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rotation matrix in cell values #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

DRollin
Copy link
Collaborator

@DRollin DRollin commented Dec 17, 2024

No description provided.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.56%. Comparing base (42da30d) to head (a4d0925).

Files with missing lines Patch % Lines
src/cellvalues.jl 93.02% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   88.61%   88.56%   -0.06%     
==========================================
  Files           5        5              
  Lines         281      306      +25     
==========================================
+ Hits          249      271      +22     
- Misses         32       35       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DRollin DRollin linked an issue Dec 17, 2024 that may be closed by this pull request
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could use some help defining a proper test case...
Not sure if the current one is fine.

@fredrikekre fredrikekre requested a review from kimauth December 17, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to get the rotation matrix of interface cell?
1 participant