Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid GraphQL schema for facetGroup conjunction/negation/disjunction #757

Closed
novoj opened this issue Dec 4, 2024 · 1 comment · Fixed by #769
Closed

Invalid GraphQL schema for facetGroup conjunction/negation/disjunction #757

novoj opened this issue Dec 4, 2024 · 1 comment · Fixed by #769
Assignees
@lukashornych
Labels
bug Something isn't working
Milestone
2025.1

Comments

@novoj
Copy link
Collaborator

novoj commented Dec 4, 2024

The schema offers attributes of the tag entity instead of tagCategory entity:

image

These constraints focus directly on reference schema group and need to offer properties of this schema instead.
@novoj novoj added the bug Something isn't working label Dec 4, 2024
@novoj novoj added this to the Beta milestone Dec 4, 2024
lukashornych added a commit that referenced this issue Jan 7, 2025
@lukashornych
fix: facetXXXGroupsXXXjunction constraint target reference entity typ…
f02527c 
…e instead of reference group type

Refs: #757
lukashornych added a commit that referenced this issue Jan 7, 2025
@lukashornych
fix: facetXXXGroupsXXXjunction constraint target reference entity typ…
079fe6d 
…e instead of reference group type

Refs: #757
@lukashornych lukashornych mentioned this issue Jan 7, 2025
Merged
@lukashornych lukashornych linked a pull request Jan 7, 2025 that will close this issue
fix: facetXXXGroupsXXXjunction constraint target reference entity type instead of reference group type #769
Merged
@lukashornych
Copy link
Collaborator

@novoj Fixed in 757-invalid-graphql-schema-for-facetgroup-conjunctionnegationdisjunction. It turns out we already had a support target group type in generating constraints. It just needed a little bit of other things to work together properly. Please test it on your usecase before merging it. I've tested it and it seems to be working.

@novoj novoj closed this as completed in #769 Jan 7, 2025
@novoj novoj modified the milestones: Beta, 2025.1 Jan 7, 2025
novoj pushed a commit that referenced this issue Jan 13, 2025
@lukashornych @novoj
fix: facetXXXGroupsXXXjunction constraint target reference entity typ…
388b584 
…e instead of reference group type

Refs: #757
(cherry picked from commit f02527c)
novoj pushed a commit that referenced this issue Jan 13, 2025
@lukashornych @novoj
fix: facetXXXGroupsXXXjunction constraint target reference entity typ…
8d9e40c 
…e instead of reference group type

Refs: #757
(cherry picked from commit 079fe6d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukashornych lukashornych

Labels
bug Something isn't working
Projects
None yet
Milestone
2025.1
2 participants
@novoj @lukashornych