Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State is not saved on error #148

Open
ivomurrell opened this issue Aug 2, 2021 · 1 comment · May be fixed by #154
Open

State is not saved on error #148

ivomurrell opened this issue Aug 2, 2021 · 1 comment · May be fixed by #154

Comments

@ivomurrell
Copy link
Contributor

ivomurrell commented Aug 2, 2021 •
edited
Loading

If you get an error when running an operation for a repository the operation will continue to execute until all repositories have either succeeded or failed. However, currently when a repository does fail the repositories that did succeed are not stored in the state, making it very hard to track which repos are safe to rerun if an operation isn't idempotent. We should look into improving interaction with immer to ensure that the mutated state is stored even if an error is thrown.

We could potentially use createDraft and finishDraft to properly handle immer drafts within a try/catch block.
ivomurrell added a commit that referenced this issue Aug 20, 2021
@ivomurrell
Catch errors in operation handlers
4fe3521 
This means we don't lose the results of the repositories that succeeded
and can continue to work on them if we like.

Closes #148
@ivomurrell ivomurrell linked a pull request Aug 20, 2021 that will close this issue
Draft
ivomurrell added a commit that referenced this issue Aug 20, 2021
@ivomurrell
Catch errors in operation handlers
b45f43a 
This means we don't lose the results of the repositories that succeeded
and can continue to work on them if we like.

Closes #148
ivomurrell added a commit that referenced this issue Nov 26, 2021
@ivomurrell
Catch errors in operation handlers
01d0e86 
This means we don't lose the results of the repositories that succeeded
and can continue to work on them if we like.

Closes #148
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 9, 2022
@ivomurrell ivomurrell removed the stale label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle operation errors gracefully Financial-Times/nori
1 participant
@ivomurrell