Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Monaco example: Firepad is not defined #368

Open
matipan opened this issue May 24, 2020 · 1 comment
Open

Monaco example: Firepad is not defined #368

matipan opened this issue May 24, 2020 · 1 comment

Comments

@matipan
Copy link

matipan commented May 24, 2020

Version info

Firebase: 7.13.2

Firepad: 1.5.9

Ace:

CodeMirror:

Other (e.g. Node, browser, operating system) (if applicable): Monaco 0.20.0

Test case

The error appeared when loading the examples.

Steps to reproduce

I cloned firepad, run npm install in the root directory, configured example/monaco.html to point to my database and then opened it up on a browser. Editor is loaded but firepad is not working and can be verified by opening up the console.

Expected behavior

Once I open up the monaco example I'd expect to have firepad collaboration working using the monaco editor for editting.

Actual behavior

The monaco editor loads up correctly but I inspect the console I see the following error:

monaco.html:53 Uncaught ReferenceError: Firepad is not defined
    at monaco.html:53
    at Function.t._invokeFactory (loader.js:1036)
    at t.complete (loader.js:1046)
    at s._onModuleComplete (loader.js:1663)
    at s._onModuleComplete (loader.js:1675)
    at s._onModuleComplete (loader.js:1675)
    at s._onModuleComplete (loader.js:1675)
    at s._onModuleComplete (loader.js:1675)
    at s._onModuleComplete (loader.js:1675)
    at s._onModuleComplete (loader.js:1675)

BTW this only happens with monaco, with codemirror it works fine.

Thanks for an awesome project!

@0xTheProDev
Copy link
Contributor

Hey @matipan, is you use-case concerns only Monaco? If so you can use @hackerrank/firepad, we have built this custom tailoured for Monaco only.
This looks to me like a build issue, but have to dig deeper.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants