Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools to help discover ambiguous routes #50

Open
Firehed opened this issue Jun 6, 2018 · 0 comments · May be fixed by #51
Open

Add tools to help discover ambiguous routes #50

Firehed opened this issue Jun 6, 2018 · 0 comments · May be fixed by #51

Comments

@Firehed
Copy link
Owner

Firehed commented Jun 6, 2018

The current matching system (and any regexp-based matching system in general) can allow you to create routes, and there is no defined behavior for what order the matches will be attempted in (in practice; it's loosely based on whatever order find returns files in).

Some loose heuristic would be to look for all test cases that use the EndpointTestTrait, combine all of their goodUris() into a list, and test for good uris that match against multiple endpoints. This can get really complicated across different request methods today, and would get even more complex should disambiguation across other request variants (e.g. accept headers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant