-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typeconverter is called for every new context (1.0) #511
Comments
@DamienM419 are you currently working on this? Would you mind assigning this ticket to yourself? |
This is fixed for 1.0 by #512 , so I suggest we keep this open until we have ported/reimplemented this fix for 2.0. |
baseTwo
changed the title
Typeconverter is called for every new context
Typeconverter is called for every new context (1.0 and 2.0)
Sep 13, 2024
This was
linked to
pull requests
Sep 17, 2024
baseTwo
changed the title
Typeconverter is called for every new context (1.0 and 2.0)
Typeconverter is called for every new context (1.0)
Sep 25, 2024
baseTwo
changed the title
Typeconverter is called for every new context (1.0)
511 Typeconverter is called for every new context (1.0)
Sep 25, 2024
baseTwo
changed the title
511 Typeconverter is called for every new context (1.0)
Typeconverter is called for every new context (1.0)
Sep 25, 2024
Creating a separate issue for 2.0 #586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using context patient and creating a new context for each bundle datasource, the creation of the context is taking about 27% of the time for 100k patients. The reason for this is because in the FhirModelBindingSetup the FhirTypeConverter.Create occurs every time when it only needs to happen once and be passed into the constructor to be reused.
To Reproduce
Create a unit test with a batch of patient bundles and create new context in a parallel foreach, profile the unit test and you will see 1 line of code eating up most of the run time for the context creation.
Expected behavior
TypeConverter creation only needs to happen one time since it's related to the CQL and not the datasource.
Screenshots
Version used:
develop branch
The text was updated successfully, but these errors were encountered: