From 6a2c26fee998122014ee435606b1433f7f390696 Mon Sep 17 00:00:00 2001 From: caozhou Date: Tue, 28 May 2024 17:59:11 +0800 Subject: [PATCH] fix some bugs --- flagscale/auto_tuner/prune/history.py | 2 +- flagscale/launcher/runner.py | 10 ---------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/flagscale/auto_tuner/prune/history.py b/flagscale/auto_tuner/prune/history.py index 8c58a33e1..886897e23 100644 --- a/flagscale/auto_tuner/prune/history.py +++ b/flagscale/auto_tuner/prune/history.py @@ -30,7 +30,7 @@ def prune_by_micro_batch_size(config, strategy, history=[]): logger.info( f"The strategy {strategy} has been pruned by micro_batch_size performance." ) - strategy["performance"] = performance + strategy["performance"] = item["performance"] strategy["max_mem"] = item["max_mem"] strategy["pruned"] = True return True diff --git a/flagscale/launcher/runner.py b/flagscale/launcher/runner.py index 9dc9db8d7..ef6c447de 100644 --- a/flagscale/launcher/runner.py +++ b/flagscale/launcher/runner.py @@ -510,11 +510,6 @@ def _run_each( cmd = shlex.join(export_cmd + runner_cmd + [self.user_script] + self.user_args) - if with_test: - exp_dir = self.config.experiment.exp_dir - test_cmd = f";python tests/functional_tests/check_result.py {exp_dir};rm -r {exp_dir}" - cmd = cmd + test_cmd - host_run_script_file = _generate_run_script( self.config, host, node_rank, cmd, background=True, with_test=with_test ) @@ -795,11 +790,6 @@ def _run_each( cmd = shlex.join(export_cmd + runner_cmd + [self.user_script] + self.user_args) - if with_test: - exp_dir = self.config.experiment.exp_dir - test_cmd = f";python tests/functional_tests/check_result.py {exp_dir};rm -r {exp_dir}" - cmd = cmd + test_cmd - host_run_script_file = _generate_run_script( self.config, host, node_rank, cmd, background=False, with_test=with_test )