Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming inconsistencies #6

Open
dcconner opened this issue Jan 23, 2018 · 1 comment
Open

Naming inconsistencies #6

dcconner opened this issue Jan 23, 2018 · 1 comment
Assignees

Comments

@dcconner
Copy link
Member

There are several files with similar names in manipulation_states that operate differently.

I propose to implement the following changes in a kinetic_devel branch

  1. GetJointsFromSrdfGroup --> GetJointNamesFromSrdfGroupState
  • Add srdf_name parameter that defaults to "/robot_description_semantic"
  • Name as "State" for consistency with other implementations
  1. GetJointsFromSrdfState --> GetJointValuesFromSrdfFileState
  • Specify that this is reading from file
  • Specify we are getting joint values from named configuration
  1. Create new GetJointValuesFromSrdfState
  • Use srdf_name and read from parameter server (otherwise same as 2)
@dcconner dcconner self-assigned this Jan 23, 2018
@dcconner
Copy link
Member Author

  1. JointStateToMoveit --> JointValuesToMoveGroupState

  2. moveit_to_joints* --> these are essentially 4 with different combinations of userdata and parameters.

  • Need consistent naming with 4.
  • Need to validate that we have the proper names and values in user data fields
  1. srdf_state_to_moveit --> NamedConfigToMoveGroupState
  2. srdf_state_moveit_execute_trajectory --> NamedConfigToMoveServiceState
  • executes move to a single position as direct trajectory service call

fmessmer added a commit to fmessmer/generic_flexbe_states that referenced this issue Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant