Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Operation Functionality #44

Open
1 of 3 tasks
0xflotus opened this issue Jan 28, 2020 · 4 comments · Fixed by #49 · May be fixed by #45 or #47
Open
1 of 3 tasks

Extend Operation Functionality #44

0xflotus opened this issue Jan 28, 2020 · 4 comments · Fixed by #49 · May be fixed by #45 or #47
Labels
enhancement good first issue help wanted

Comments

@0xflotus
Copy link
Contributor

0xflotus commented Jan 28, 2020 •
edited by FlorianWendelborn
Loading

Can you please implement bit shift operations like logical shift, arithmetic shift and cyclic shift ?
@FlorianWendelborn
Copy link
Owner

Sorry, don’t have time for this right now, if you (or anyone else) want(s) to pick this up feel free to send a PR.

This was referenced Oct 13, 2020
Open
Closed
Open
@FlorianWendelborn
Copy link
Owner

@0xflotus thanks for the PRs, I’m willing to get them merged soon. However, I left a couple questions on the individual pull requests

In general, this looks very mergeable already, pretty much only a few minor nitpicks open regarding public API.

@0xflotus
Copy link
Contributor Author

Are all commits fine?

@FlorianWendelborn
Copy link
Owner

@0xflotus yes, I think so, I’m unfortunately just very busy right now. It’s still on my radar though 😞

FlorianWendelborn pushed a commit that referenced this issue Feb 18, 2021
@0xflotus @FlorianWendelborn
feature(#44): Added Circular Shift
f8abc96
FlorianWendelborn pushed a commit that referenced this issue Feb 18, 2021
@0xflotus @FlorianWendelborn
feature(#44): Added Circular Shift
db4f734
FlorianWendelborn pushed a commit that referenced this issue Feb 18, 2021
@0xflotus @FlorianWendelborn
feature(#44): Added Circular Shift
bf411a7
FlorianWendelborn added a commit that referenced this issue Feb 18, 2021
@FlorianWendelborn
feature(#44): Support Arbitrary-Width Shifts, Add More Test Cases, Ad…
5d8cce7 
…d Readme
FlorianWendelborn pushed a commit that referenced this issue Feb 18, 2021
@0xflotus @FlorianWendelborn
feature(#44): Added Circular Shift
e524183
FlorianWendelborn added a commit that referenced this issue Feb 18, 2021
@FlorianWendelborn
feature(#44): Support Arbitrary-Width Shifts, Add More Test Cases, Ad…
983d572 
…d Readme
@FlorianWendelborn FlorianWendelborn linked a pull request Feb 18, 2021 that will close this issue
feature(#44): Add Circular Shift #49
Merged
FlorianWendelborn added a commit that referenced this issue Feb 18, 2021
@FlorianWendelborn
feature(#44): Support Arbitrary-Width Shifts, Add More Test Cases, Ad…
f438b07 
…d Readme
FlorianWendelborn added a commit that referenced this issue Feb 18, 2021
@FlorianWendelborn
feature(#44): Support Arbitrary-Width Shifts, Add More Test Cases, Ad…
26c608e 
…d Readme
FlorianWendelborn added a commit that referenced this issue Feb 18, 2021
@FlorianWendelborn
feature(#44): Support Arbitrary-Width Shifts, Add More Test Cases, Ad…
768ce7f 
…d Readme
FlorianWendelborn added a commit that referenced this issue Feb 18, 2021
@FlorianWendelborn
feature(#44): Support Arbitrary-Width Shifts, Add More Test Cases, Ad…
d97e42a 
…d Readme
FlorianWendelborn added a commit that referenced this issue Feb 18, 2021
@FlorianWendelborn
Merge pull request #49 from FlorianWendelborn/0xflotus-circular-shift
59c5e56 
feature(#44): Add Circular Shift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
2 participants
@FlorianWendelborn @0xflotus