Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5355 Show forwarded message content #5457

Merged
merged 9 commits into from
Oct 19, 2023

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Oct 16, 2023

This PR updated forward functionality to include forward header information and show forwarded message content

close #5355 // if this PR closes an issue


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226
Copy link
Collaborator Author

@sosnovsky Now forward looks like this.
Let me know if you are happy with this.
I'll start to work on fixing tests. Not sure why so many tests fail though
image

@sosnovsky
Copy link
Collaborator

It looks great 👍

I just noticed bug with forwarded message content - on recipient side forwarded message text is merged into 1 line, so it looks like this:

Screenshot 2023-10-17 at 20 53 10

@ioanmo226
Copy link
Collaborator Author

Thanks. Let me check and fix

@ioanmo226 ioanmo226 marked this pull request as ready for review October 19, 2023 05:15
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner October 19, 2023 05:15
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, looks much better now 👍

@sosnovsky sosnovsky merged commit 5b7cf40 into master Oct 19, 2023
8 checks passed
@sosnovsky sosnovsky deleted the 5355-forwarded-message-content-should-be-visible branch October 19, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forwarded message content should be visible
2 participants