Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form node does not pass on topic when configured to do so #1453

Open
colinl opened this issue Nov 9, 2024 · 6 comments · May be fixed by #1483
Open

Form node does not pass on topic when configured to do so #1453

colinl opened this issue Nov 9, 2024 · 6 comments · May be fixed by #1483
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do

Comments

@colinl
Copy link
Contributor

colinl commented Nov 9, 2024

Current Behavior

When a form is configured with the Topic field set to msg.topic, then if a message with a topic is passed in then that topic should be passed on when the form is submitted. In this example flow that is not happening, the passed on topic is always an empty string.

[{"id":"782b20ba75db1d98","type":"inject","z":"bdd7be38.d3b55","name":"topic: 7","props":[{"p":"topic","v":"7","vt":"num"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":250,"y":3680,"wires":[["93af822611e1a3bd"]]},{"id":"93af822611e1a3bd","type":"ui-form","z":"bdd7be38.d3b55","name":"","group":"4f87bd59a15b847e","label":"Test form","order":0,"width":0,"height":0,"options":[{"label":"","key":"formValue","type":"text","required":true,"rows":null}],"formValue":{"formValue":""},"payload":"","submit":"submit","cancel":"clear","resetOnSubmit":true,"topic":"topic","topicType":"msg","splitLayout":"","className":"","passthru":false,"dropdownOptions":[],"x":470,"y":3680,"wires":[["c47d1b4e28c96bb3"]]},{"id":"c47d1b4e28c96bb3","type":"debug","z":"bdd7be38.d3b55","name":"debug 87","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":630,"y":3680,"wires":[]},{"id":"f0ca8088245f8e89","type":"inject","z":"bdd7be38.d3b55","name":"topic: 42","props":[{"p":"topic","v":"42","vt":"num"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":260,"y":3740,"wires":[["93af822611e1a3bd"]]},{"id":"4f87bd59a15b847e","type":"ui-group","name":"test","page":"c6ff182a4185f2f2","width":"6","height":"1","order":1,"showTitle":false,"className":"","visible":"true","disabled":"false"},{"id":"c6ff182a4185f2f2","type":"ui-page","name":"Test page","ui":"ID-BASE-1","path":"/testpage","icon":"home","layout":"grid","theme":"f9b6670b127dc219","order":2,"className":"","visible":"true","disabled":"false"},{"id":"ID-BASE-1","type":"ui-base","name":"Dashboard","path":"/dashboard","includeClientData":true,"acceptsClientConfig":["ui-control","ui-notification","ui-gauge-classic"],"showPageTitle":true,"titleBarStyle":"default"},{"id":"f9b6670b127dc219","type":"ui-theme","name":"FlowForge Theme","colors":{"surface":"#152a47","primary":"#005aff","bgPage":"#ffffff","groupBg":"#ffffff","groupOutline":"#cc3e3e"},"sizes":{"pagePadding":"12px","groupGap":"12px","groupBorderRadius":"4px","widgetGap":"12px"}}]

Expected Behavior

No response

Steps To Reproduce

No response

Environment

  • Dashboard version: 1.19.1
  • Node-RED version: 4.0.5
  • Node.js version: 20.5.1
  • npm version:
  • Platform/OS: Ubuntu
  • Browser: Edge

Have you provided an initial effort estimate for this issue?

I am not a FlowFuse team member
@colinl colinl added bug Something isn't working needs-triage Needs looking at to decide what to do labels Nov 9, 2024
@cgjgh cgjgh linked a pull request Nov 19, 2024 that will close this issue
Open
10 tasks
@joepavitt
Copy link
Collaborator

joepavitt commented Nov 29, 2024 •
edited
Loading

Can I check my understanding here, you're expecting an incoming msg to store in the form until the form is submitted, then use that stored msg.topic when the form is submitted?

That feels quite Node-RED antipattern?

@colinl
Copy link
Contributor Author

colinl commented Nov 29, 2024

Can I check my understanding here, you're expecting an incoming msg to store in the form until the form is submitted, then use that stored msg.topic when the form is submitted?

What else could configuring the topic to msg.topic mean?

@colinl
Copy link
Contributor Author

colinl commented Nov 30, 2024

The equivalent operation works with a Switch node. If you configure the topic to be msg.topic and then send in a valid message with a topic, then that topic will be used for subsequent switch operations.

@colinl
Copy link
Contributor Author

colinl commented Dec 1, 2024

Note that I do not consider this to be high priority, it is not a common use case.

@bartbutenaers
Copy link
Contributor

@colinl,
I had a (very) quick view at the code of the form node, and I don't think it is implemented at all. It will have got lost somewhere. Anyway will try to find some time tonight to implement it similar to the Switch node.

@colinl
Copy link
Contributor Author

colinl commented Dec 1, 2024

As I said, it is not a high priority, personally I do not have a need for it, I just found it by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do
Projects
Dashboard Backlog
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Form - Fix form node not passing on msg.topic on submit cgjgh/node-red-dashboard
4 participants
@colinl @bartbutenaers @joepavitt and others