Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set height of image to height of dialog #5

Closed
sveinnetnordic opened this issue Oct 8, 2024 · 1 comment · Fixed by #6
Closed

Set height of image to height of dialog #5

sveinnetnordic opened this issue Oct 8, 2024 · 1 comment · Fixed by #6
Assignees

Comments

@sveinnetnordic
Copy link

Feature proposal

For high resolution images I am getting a long vertical scrollbar, making it hard to use. I am using the sample code with the dialog. As a tip from @javier-godoy I am setting image-crop img { height: 100vh }. I am getting a small scrollbar, but it is OK. I think setHeightFull() etc would be a much cleaner solution. Maybe width to...

Describe solution expectations

No response

Additional information

No response

@github-project-automation github-project-automation bot moved this to Inbox (needs triage) in Flowing Code Addons Oct 8, 2024
@sveinnetnordic
Copy link
Author

This works best for small and large images. The dialog is resizable and dragable. If resized the overlay will not be resized until moved with mouse. Seems that setting key={uniqueImageKey} kan trigger that: sekoyo/react-image-crop#585
image

@paodb paodb self-assigned this Oct 31, 2024
@paodb paodb moved this from Inbox (needs triage) to To Do in Flowing Code Addons Nov 4, 2024
paodb added a commit that referenced this issue Nov 4, 2024
@github-project-automation github-project-automation bot moved this from To Do to Done in Flowing Code Addons Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants