Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub API Integration #8

Open
Zambrella opened this issue Dec 26, 2020 · 11 comments
Open

GitHub API Integration #8

Zambrella opened this issue Dec 26, 2020 · 11 comments
Assignees
Labels
discussion Open to discussion enhancement New feature or request

Comments

@Zambrella
Copy link

No description provided.

@Zambrella
Copy link
Author

@joeyda3rd joeyda3rd self-assigned this Dec 27, 2020
@joeyda3rd
Copy link
Contributor

@joeyda3rd
Copy link
Contributor

I have the org repos being pulled into a list of 'repo' objects. It can be passed in a stream or future, whatever we want.

@slovnicki
Copy link
Contributor

slovnicki commented Dec 28, 2020

@joeyda3rd Cool. Check out the project.dart and project_repository.dart for relevant information about where and how should those repos come.

It's a little tricky naming now due to github "repository" name, but that corresponds to "project"

@slovnicki
Copy link
Contributor

If that github package is being used and it returns some internal object and not JSON, some modifications will be needed, like adding a new constructor to Project, as we now only have .fromJson

@joeyda3rd
Copy link
Contributor

Ya, it's being used and it does return an object but it literally took me 5 minutes. I can just as easily return a JSON. In fact, here's the response. https://api.github.com/orgs/Flutter-Buddies/repos

@slovnicki
Copy link
Contributor

that's nice. Are you working on this or can I just plug that in now?

@joeyda3rd
Copy link
Contributor

Go ahead and plug it in since you've got it set up. There's a little bit of scrubbing to do to "name" to remove dashes. I was just going to use String.replaceAll(). Description is fine as is. Not sure what to do about getting an image. Create an image file in the repo with a standard name? For the ongoing tag, maybe we can use either the 'archived' or 'disabled', boolean?

@slovnicki
Copy link
Contributor

Ok. I'll now just plug it in with basic data and then you and @Zambrella can play around with which else data we want to show in app, as there is really a lot of cool data. Then you'll be just improving on Project attributes and ProjectCard attributes.

@slovnicki
Copy link
Contributor

Ok, now it's using real API. I left the image to be random and didn't format name. You can do that. I'm gonna step off this issue now for a while, at least implementation-wise.

@slovnicki slovnicki added discussion Open to discussion enhancement New feature or request labels Dec 31, 2020
@joeyda3rd
Copy link
Contributor

Need to catch null response fields.

@joeyda3rd joeyda3rd changed the title Look into using GitHub API to get info on current Flutter Buddies projects GitHub API Integration Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open to discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants