Generation script issues

[jtanx]

So... While trying to debug fontforge/fontforge#3145 I ran into a few gems...

fontcustom/lib/fontcustom/scripts/generate.py

Line 118 in e5bbc45

subprocess.Popen([scriptPath + '/sfnt2woff.exe', fontfile + '.ttf'], stdout=subprocess.PIPE)

• Why are we using / in place of os.path.join?
• Why are we Popening without waiting for it to finish??? Why not use subprocess.check_output? Why is it even piping stdout???
• At least on Windows, a failure to run due to it being missing raises a FileNotFoundError instead of an OSError (one and the same)

fontcustom/lib/fontcustom/scripts/generate.py

Line 125 in e5bbc45

subprocess.call(['sfnt2woff', fontfile + '.ttf'])

• So now we're using subprocess.call instead of subprocess.Popen?

fontcustom/lib/fontcustom/scripts/generate.py

Line 129 in e5bbc45

subprocess.call('python ' + scriptPath + '/eotlitetool.py ' + fontfile + '.ttf -o ' + fontfile + '.eot', shell=True)

• Why are we calling python to run another python script, moreover one that is in this repo? How do we even know that the python that's called is the same python that's used to execute this script?
• Why is shell=True?????

fontcustom/lib/fontcustom/scripts/eotlitetool.py

Line 450 in e5bbc45

options, args = p.parse_args()

• Hmm... let's read in the output file name

fontcustom/lib/fontcustom/scripts/eotlitetool.py

Line 458 in e5bbc45

eot = eotname(f)

• loljk I know better!

fontcustom/lib/fontcustom/scripts/generate.py

Line 132 in e5bbc45

subprocess.call('move ' + fontfile + '.eotlite ' + fontfile + '.eot', shell=True)

• WELL ACTUALLY LET'S MOVE THE FILE BACK TO WHAT I SAID IT SHOULD BE
• USING A SHELL COMMAND
• BECAUSE os.rename IS TOO HARD
• BECAUSE FIXING eotlitetool.py IS TOO HARD

(apologies for the caps... by this point my mind was blown)

fontcustom/lib/fontcustom/scripts/generate.py

Line 138 in e5bbc45

subprocess.call('woff2_compress \'' + fontfile + '.ttf\'', shell=True)

• What's with all these shell commands? Single quoting e.g. woff2_compress 'blah.ttf' just doesn't work on Windows/cmd.exe

I'm done...