From bcf2cf1ec420fdbccd90422ba96855ed526d21f0 Mon Sep 17 00:00:00 2001 From: Melvin Chen Date: Wed, 28 Feb 2024 11:02:48 -0800 Subject: [PATCH] Upgrade node versions, remove side effect, use named exports --- .github/workflows/storybook-tests.yml | 8 ++++---- packages/nuka/package.json | 2 +- packages/nuka/src/index.tsx | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/storybook-tests.yml b/.github/workflows/storybook-tests.yml index e7226a98..5bd0d425 100644 --- a/.github/workflows/storybook-tests.yml +++ b/.github/workflows/storybook-tests.yml @@ -5,13 +5,13 @@ jobs: timeout-minutes: 60 runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: pnpm/action-setup@v2.2.2 + - uses: actions/checkout@v4 + - uses: pnpm/action-setup@v3.0.0 with: version: 7 - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: - node-version: ${{ matrix.node-version }} + node-version: 18.x - name: Install dependencies run: pnpm install - name: Install Playwright diff --git a/packages/nuka/package.json b/packages/nuka/package.json index e12050a3..db036764 100644 --- a/packages/nuka/package.json +++ b/packages/nuka/package.json @@ -93,7 +93,7 @@ "url": "https://github.com/FormidableLabs/nuka-carousel/issues" }, "homepage": "https://github.com/FormidableLabs/nuka-carousel", - "sideEffects": true, + "sideEffects": false, "publishConfig": { "provenance": true } diff --git a/packages/nuka/src/index.tsx b/packages/nuka/src/index.tsx index 67e81da6..012d06ae 100644 --- a/packages/nuka/src/index.tsx +++ b/packages/nuka/src/index.tsx @@ -1 +1 @@ -export { Carousel as default, SlideHandle } from './Carousel/Carousel'; +export { Carousel, SlideHandle } from './Carousel/Carousel';