Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless 3 Umbrella #292

Open
8 tasks
ryan-roemer opened this issue Jun 23, 2022 · 4 comments
Open
8 tasks

Serverless 3 Umbrella #292

ryan-roemer opened this issue Jun 23, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@ryan-roemer
Copy link
Member

ryan-roemer commented Jun 23, 2022

Plan

  • Only integrate with serverless 3+
    • Handle all warnings
  • Use trace-pkg
    • Will need to expose glob library. Consider a refactor/abstraction of glob library first because of ESM issues.
  • Remove benchmarks / big test scenarios
  • Consider removing inspectdep / legacy mode altogether (or ticket for later re-introduction)
  • Definitely semver major

Tasks

  • Close out all old tickets
@ryan-roemer ryan-roemer added the enhancement New feature or request label Jun 23, 2022
@ryan-roemer ryan-roemer added this to the Serverless 3 milestone Jun 23, 2022
@jeanbmar
Copy link

jeanbmar commented Sep 6, 2022

Hey @ryan-roemer, you might want to have a look at this npm/cli#4082 if you plan to change packaging in the future.
I'm using for non-serverless projects and its pretty good. Hopefully it will land in npm.
Btw love this tool thanks!

@ryan-roemer
Copy link
Member Author

@jeanbmar Cool! that's an option if we keep legacy mode as a potential replacement for our inspectdep library if it's faster.

Either approach is going to likely be slower and definitely produce large bundles than Jetpacks trace mode -- out of curiosity, have you tried trace mode for faster, smaller Lambda bundles?

@jeanbmar
Copy link

jeanbmar commented Sep 6, 2022

I haven't tried it, at least not yet.
I was worried of possible subtile side-effects at the time I looked at it so I just went with the default packaging :).

@jeanbmar
Copy link

jeanbmar commented Sep 15, 2022

Hey @ryan-roemer, you might want to have a look at this npm/cli#4082 if you plan to change packaging in the future. I'm using for non-serverless projects and its pretty good. Hopefully it will land in npm. Btw love this tool thanks!

In addition, it would solve collapsed dependencies issues since npm copy installs conflicting dependencies in the right subdirectories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants