Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: enable feature flag to avoid rendering / minimize use of FontAwesome server side #413

Open
3 tasks done
CarlosTorrecillas opened this issue Aug 30, 2023 · 0 comments

Comments

@CarlosTorrecillas
Copy link

Describe the problem you'd like to see solved or task you'd like to see made easier

I am trying to optimize the performance of Angular APPs by disabling server side all functionality related to FontAwesome and running / rendering the icons client side.

Is this in relation to an existing part of angular-fontawesome or something new?

I think this would be something new

What is 1 thing that we can do when building this feature that will guarantee that it is awesome?

Setting up a feature flag to render icons server side at module definition level would have minimum impact and would affect the entire site. I know that you can go one by one through your components and do "isServer" and things like that. But this is very tedious and sometimes requires extra actions or checks that shouldn't be needed if we had a global setting to determine whether or not icons should be rendered and FontAwesome could be kind of "disabled" if that makes sense.

Why would other angular-fontawesome users care about this?

If you create this flag defaulted to true it would be backwards compatible so that other users wouldn't notice. When importing the FontAwesome module you could define that property so that existing users that want to adopt this feature would have minimum impact I think.

On a scale of 1 (sometime in the future) to 10 (absolutely right now), how soon would you recommend we make this feature?

8 . I think it is very powerful and will have great impact

Feature request checklist

  • This is a single feature (i.e. not a re-write of all of Font Awesome)
  • The title starts with "Feature request: " and is followed by a clear feature name (Ex: Feature request: moar cowbell)
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant