You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the problem you'd like to see solved or task you'd like to see made easier
FontAwesome provides a way to rotate an icon by any custom value. You can add the class fa-rotate-by and then set the CSS variable --fa-rotate-angle. E.g. from https://docs.fontawesome.com/web/style/rotate
This doesn't not seem to be possible using the Angular component because the rotate property is set to the type RotateProp which only allows the values which correspond to fa-rotate-90, fa-rotate-180, and fa-rotate-270.
Is this in relation to an existing part of angular-fontawesome or something new?
Existing functionality of the rotate property of FaIcon. I am suggesting a slight change to the accepted values and subsequent behavior. My suggestion is that the rotate property be changed to accept numbers and if the number is 90, 180, or 270 exactly then you can simply add the corresponding fa-rotate-* class but if it's any other number then add the fa-rotate-by class and a style similar to the example given above
What is 1 thing that we can do when building this feature that will guarantee that it is awesome?
Instead of creating a new property such as rotateBy just change the behavior of the current rotate property which shouldn't break anyone's code.
Why would other angular-fontawesome users care about this?
Because it's a part of FontAwesome for web and just not implemented in the Angular components.
On a scale of 1 (sometime in the future) to 10 (absolutely right now), how soon would you recommend we make this feature?
11! Ok, just kidding. I'm going to say 9 since this seems like a super easy change with with good value I would label this change "low hanging fruit", easy to pick. :-)
Feature request checklist
This is a single feature (i.e. not a re-write of all of Font Awesome)
The title starts with "Feature request: " and is followed by a clear feature name (Ex: Feature request: moar cowbell)
Describe the problem you'd like to see solved or task you'd like to see made easier
FontAwesome provides a way to rotate an icon by any custom value. You can add the class
fa-rotate-by
and then set the CSS variable--fa-rotate-angle
. E.g. from https://docs.fontawesome.com/web/style/rotateThis doesn't not seem to be possible using the Angular component because the
rotate
property is set to the type RotateProp which only allows the values which correspond tofa-rotate-90
,fa-rotate-180
, andfa-rotate-270
.Is this in relation to an existing part of angular-fontawesome or something new?
Existing functionality of the
rotate
property of FaIcon. I am suggesting a slight change to the accepted values and subsequent behavior. My suggestion is that therotate
property be changed to accept numbers and if the number is 90, 180, or 270 exactly then you can simply add the corresponding fa-rotate-* class but if it's any other number then add the fa-rotate-by class and a style similar to the example given aboveWhat is 1 thing that we can do when building this feature that will guarantee that it is awesome?
Instead of creating a new property such as
rotateBy
just change the behavior of the current rotate property which shouldn't break anyone's code.Why would other angular-fontawesome users care about this?
Because it's a part of FontAwesome for web and just not implemented in the Angular components.
On a scale of 1 (sometime in the future) to 10 (absolutely right now), how soon would you recommend we make this feature?
11! Ok, just kidding. I'm going to say 9 since this seems like a super easy change with with good value I would label this change "low hanging fruit", easy to pick. :-)
Feature request checklist
Feature request: moar cowbell
)The text was updated successfully, but these errors were encountered: