Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i need to set a different keyboard height for both screen orientations each #84

Open
6 of 7 tasks
sosasees opened this issue Sep 7, 2024 · 4 comments
Open
6 of 7 tasks
Labels
enhancement New feature or request

Comments

@sosasees
Copy link

sosasees commented Sep 7, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

i need to set the keyboard height separately for portrait mode and for landscape mode

Why do you want this feature?

the keyboard height of 100% is just right in portrait mode but too tall in landscape mode:

IMG_20240907_174250 IMG_20240907_174315

and the keyboard height of 70% is more like it in landscape mode but too short in portrait mode:

IMG_20240907_180925 IMG_20240907_180811


image disclaimers:

  • the images are stored in the WebP format to save some of your bandwidth
    but GitHub doesn't allow .webp images in issues so i tricked GitHub by changing the filename extension to .png but the files itselves are still in WebP format
  • i edited the portrait mode images into the 9:16 aspect ratio for your viewing convenience.
    my phone screen is actually taller, which can be seen in the landscape mode examples

Additional information

my phone screen — the part that lights up — is 19⁷⁄₁₆ × 8¾ cenbimeters big.
that makes the aspect ratio approximately 3:6⅔, or 2:4⅖, or 1:2.221

@sosasees sosasees added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Sep 7, 2024
@Aga-C Aga-C added enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Sep 7, 2024
@naveensingh
Copy link
Member

naveensingh commented Sep 18, 2024

Instead of offering two settings, it's the keyboard-height/resizing feature that needs to be improved so it works better both in landscape and portrait modes.

The whole thing could be reworked similar to how Gboard and SwiftKey do it but that's for later.

@naveensingh naveensingh removed the needs triage Issue is not yet ready for PR authors to take up label Sep 18, 2024
@sosasees
Copy link
Author

The whole thing could be reworked similar to how Gboard and SwiftKey do

i haven't used either of these keyboards, so please explain

@naveensingh
Copy link
Member

Gboard and Swiftkey:

@sosasees
Copy link
Author

ah, resize handles like in Samsung keyboard too.

that is the best UI to resize the keyboard.

but before we can make this more advanced resizing UI, we have to split the existing keyboard height setting between portrait mode and landscape mode to get a solid base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants