Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extreme performance issues when scrolling downwards in App Drawer #65

Closed
7 tasks done
ikcikoR opened this issue Nov 1, 2024 · 21 comments · Fixed by #78
Closed
7 tasks done

Extreme performance issues when scrolling downwards in App Drawer #65

ikcikoR opened this issue Nov 1, 2024 · 21 comments · Fixed by #78
Labels
bug Something is not working

Comments

@ikcikoR
Copy link

ikcikoR commented Nov 1, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.0

Affected Android/Custom ROM version

One UI 6.1 (Android 14)

Affected device model

Samsung Galaxy A53 5G (SM-A536B/DS)

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

  1. Open app drawer.
  2. Scroll down.

Expected behavior

Framerate not dropping abysmally when scrolling downwards in app drawer.

Actual behavior

Framerate drops abysmally when scrolling downwards in app drawer.

Screenshots/Screen recordings

Recorder_20241101192915.mp4

Additional information

No response
@ikcikoR ikcikoR added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Nov 1, 2024
@h0113r3r
Copy link

h0113r3r commented Nov 2, 2024

Observation:
If one force kills the launcher in the app settings it seems to work fine for a while.

@Aga-C
Copy link
Member

Aga-C commented Nov 3, 2024

How many apps do you have installed?

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Nov 3, 2024
@naveensingh
Copy link
Member

This also happens on one of my devices running Android 13, it has around 100 apps.

@Aga-C Aga-C removed question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. needs triage Issue is not yet ready for PR authors to take up labels Nov 3, 2024
@h0113r3r
Copy link

h0113r3r commented Nov 3, 2024

@Aga-C 47 on Android 14 GSI.

@ikcikoR
Copy link
Author

ikcikoR commented Nov 3, 2024 •
edited
Loading

How many apps do you have installed?

102 icons in the app drawer, force killing the app did fix the issue temporarily but it came back gradually and is just as bad as before after a day or two so it feels like some memory leak adjacent issue.

@ikcikoR
Copy link
Author

ikcikoR commented Nov 3, 2024

Total amount of apps including system apps and apps without icons in the launcher seems to be 160 according to my phone's settings.

@naveensingh
Copy link
Member

Here's an APK with a potential fix:

launcher.apk.zip (remove the .zip, do not extract)

Please let me know if it works.

@h0113r3r
Copy link

h0113r3r commented Nov 7, 2024

thanks for the update!
it's better but the framerate of scrolling down tge app drawer is still bad in contrast to scrolling up...

@MichaelMcDonnell
Copy link
Contributor

I have 72 apps on my Pixel 8 and scrolling down is choppy, It's more like lots of micro stutters. Scrolling up is fine.

@MichaelMcDonnell
Copy link
Contributor

MichaelMcDonnell commented Dec 14, 2024 •
edited by fossifybot
Loading

I turned on HWUI and much more work is done when scrolling down vs scrolling up (I first scroll down then up in the screenshot). Most of the time is spent in the "Input Handling & Animation" and "Misc Time / VSync Delay" categories.

Fossify Launcher scroll down vs scroll up performance HWUI (scaled)

@MichaelMcDonnell
Copy link
Contributor

@ikcikoR could you try to comment out the two places in the code in allAppsFragment.kt that hides the keyboard? When I do that the HWUI profile looks more or less the same dragging up and down.

MichaelMcDonnell added a commit to MichaelMcDonnell/Launcher that referenced this issue Dec 15, 2024
@MichaelMcDonnell
Fix scroll down performance
e27628b 
Scrolling down was slow (see issue FossifyOrg#65) because the keyboard was being
hidden every time scroll down event. Hiding the keyboard is an expensive
operation (found through profiling). They keyboard only needs to be hidden
if the search bar is being used (in focus).
MichaelMcDonnell added a commit to MichaelMcDonnell/Launcher that referenced this issue Dec 15, 2024
@MichaelMcDonnell
Fix scroll down performance
76a2509 
Scrolling down was slow (see issue FossifyOrg#65) because the keyboard was being
hidden every time there was a scroll down event. Hiding the keyboard is
an expensive operation (found through profiling). They keyboard only needs
to be hidden if the search bar is being used (in focus).
@MichaelMcDonnell MichaelMcDonnell mentioned this issue Dec 15, 2024
Merged
2 tasks
@MichaelMcDonnell
Copy link
Contributor

@ikcikoR and @h0113r3r can I get you to test my changes in pull request #78?

@ikcikoR
Copy link
Author

ikcikoR commented Dec 22, 2024

@ikcikoR and @h0113r3r can I get you to test my changes in pull request #78?

I can try. I'd have to compile it myself, right?
In any case, usually takes a bit until the performance issues start happening so it'll take a moment before I can confirm if it got fixed or not.

@MichaelMcDonnell
Copy link
Contributor

@ikcikoR Correct, you will need to download the source code and compile it with Android Studio. I'm happy to help over chat or voice if you have more questions. My email is [email protected]

@ikcikoR
Copy link
Author

ikcikoR commented Dec 23, 2024

@ikcikoR Correct, you will need to download the source code and compile it with Android Studio. I'm happy to help over chat or voice if you have more questions. My email is [email protected]

No worries, I figured it out. Will install soon and update you in a week max as to whether the issue is still occurring or not.

image

@ikcikoR
Copy link
Author

ikcikoR commented Dec 23, 2024

Ok I did run into some issues related to apk signature but I'll look into how to solve them in a sec

@ikcikoR
Copy link
Author

ikcikoR commented Dec 23, 2024

Ok I did run into some issues related to apk signature but I'll look into how to solve them in a sec

Yep, figured it out, already installed and the correct way to build this time around

@ikcikoR
Copy link
Author

ikcikoR commented Dec 24, 2024

@MichaelMcDonnell alright, I've been using the fork for 2 days now and the performance is good when both scrolling up and down.

I'm not 100% sure yet but it feels like this also might've fixed the problem of the app becoming laggier over time in general, the non-forked version would sometimes completely freeze after a few days and I'd need to force kill the process through app settings to make it work again at all.

@MichaelMcDonnell
Copy link
Contributor

Thanks @ikcikoR! That's great! @naveensingh can I get you to pull my fix in #78?

@naveensingh
Copy link
Member

Pulled!

@MichaelMcDonnell
Copy link
Contributor

@naveensingh Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix scroll down performance MichaelMcDonnell/Launcher
5 participants
@MichaelMcDonnell @naveensingh @ikcikoR @Aga-C @h0113r3r