Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving items into Recycle Bin is not working #174

Open
7 tasks done
odinokov0 opened this issue May 25, 2024 · 8 comments
Open
7 tasks done

Moving items into Recycle Bin is not working #174

odinokov0 opened this issue May 25, 2024 · 8 comments
Labels
enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up

Comments

@odinokov0
Copy link

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.1

Affected Android/Custom ROM version

Android 13 / MIUI 14.0.4

Affected device model

Xiaomi Poco X5 5G

How did you install the app?

Third-party website

Steps to reproduce the bug

  1. Going to Settings and selecting Move items into the Recycle Bin instead of deleting
  2. Selecting or entering conversation and pressing Recycle Bin icon

Expected behavior

Expecting message to be moved into Recycle Bin

Actual behavior

Message is just deleting and Recycle Bin is still empty showing 0 messages

Screenshots/Screen recordings

No response

Additional information

No response

@odinokov0 odinokov0 added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels May 25, 2024
@Aga-C Aga-C added enhancement New feature or request and removed bug Something is not working labels May 25, 2024
@Aga-C
Copy link
Member

Aga-C commented May 25, 2024

Currently, we don't have support for moving entire conversations to the recycle bin. As the dialog states, it completely removes it from your device.

If you want to remove the entire conversation with a possibility to revert it, you have currently two possibilities:

  • Select a single message in a conversation, tap the three dots menu, choose Select all, and then press the recycle bin icon. It will move all messages to the recycle bin. The conversation will still be visible in the list, but without any messages.
  • You can also move conversation to the archive. You won't see the conversation on the list, but when receiving a new message, it will be reverted along with all messages in it.

@s38b35M5
Copy link

s38b35M5 commented Jun 4, 2024

@Aga-C I can understand that you don't see this as a bug as it is functioning as you intend, but the wording of the settings doesn't seem to limit the recycling bin to individual messages, and since whole conversations are just as likely, or even more likely to be deleted, this will be perceived as a bug by most users.

Considering it presents as an option to move all deleted items (including conversations) to recycle bin, where you can later decide to empty it, and in reality, the conversation deletes permanently, users will lose data they may have thought they were not in danger of losing.

I humbly suggest that if you cannot add the function to recycle whole conversations, then the wording of the option, and the conversation confirmation dialog should be updated to explicitly detail this behavior. This should be considered a bug until then.

@rsb-23
Copy link

rsb-23 commented Jul 3, 2024

In my case, I had just 1 message within the conversation.
So, I clicked 🗑️ icon and deleted directly without selecting the message.
For a user, message and conversation are same thing here. Hence this is a bug from users' POV.

If one has enabled recycle bin, then deleted SMS should go to recycle bin in all cases.
Expecting the same behavior, I just deleted 2 of my msgs /conversations. 😅

Hoping to raise a PR as soon as I am available.

@ASAJFM
Copy link

ASAJFM commented Jan 4, 2025

I also lost a message, I thought it would end up in the Recycle Bin where I could erase it at some stage in the future, but when I looked in the Bin there was nothing there, not exactly the behaviour I was expecting...

I'd like to take this one step further, I know it's closed-source but the Messages app on my Samsung smartphone has a recycle bin where the messages are automatically erased after 30 days, which I think is an excellent idea, it gives you a month, just in case you realise you've erased something by mistake. Could you implement this?

So how about a Message Archive, for stuff that you want to keep long term (but you want it out of the day to day message list), and a recycle bin where messages disappear forever after a specified time ?

@rsb-23
Copy link

rsb-23 commented Jan 5, 2025

I'd like to take this one step further, I know it's closed-source but the Messages app on my Samsung smartphone has a recycle bin where the messages are automatically erased after 30 days, which I think is an excellent idea, it gives you a month, just in case you realise you've erased something by mistake. Could you implement this?

Of all the messengers I've tried, Microsoft's SMS Organizer (Classic UI) seems the best. Hopefully, we get a FOSS alternative for it. ✌🏼

@ASAJFM
Copy link

ASAJFM commented Jan 12, 2025

Currently, we don't have support for moving entire conversations to the recycle bin.....

Hi @Aga-C . Can I ask, are you considering adding support for this? And if so, more or less when?

@naveensingh
Copy link
Member

To be honest, I never liked the idea of recycle bin in a messaging app and I'm thinking of removing it in favor of the archive feature.

The archive feature is simple and enough for most use-cases, we could optionally add a 'Automatically delete archived messages after 30 days' option for those who want it to act like a recycle bin.

@ASAJFM
Copy link

ASAJFM commented Jan 12, 2025

I think the "Automatically delete archived messages after 30 days" option which you have just suggested is an excellent idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up
Projects
None yet
Development

No branches or pull requests

6 participants