Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to skip silence. #31

Open
6 of 7 tasks
RokeJulianLockhart opened this issue Feb 26, 2024 · 5 comments
Open
6 of 7 tasks

Allow the user to skip silence. #31

RokeJulianLockhart opened this issue Feb 26, 2024 · 5 comments
Labels
feature request Issue is about a new feature in the app

Comments

@RokeJulianLockhart
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

Skip audio which would be considered silent. I realize that the implementation shall involve some kind of threshold, so to prevent it being arbitrary, allow the user to configure the decibel level.

Why do you want this feature?

Because I record lots of meetings. There's lots of undesired waiting as papers are brought through and organized.

Additional information

Reported here due to you-apps/RecordYou#189 (comment). Reported because https://github.com/FossifyOrg/Voice-Recorder/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+skip+silence returned 0 results.

@RokeJulianLockhart RokeJulianLockhart added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Feb 26, 2024
@inson1
Copy link

inson1 commented Feb 26, 2024

@RokeJulianLockhart time should be also configuratable? I mean how long silences should be skipped?

@Aga-C
Copy link
Member

Aga-C commented Feb 26, 2024

Do you mean automated pausing/resuming while recording when silence is detected, or fast-forward during silence on playback?

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Feb 26, 2024
@RokeJulianLockhart
Copy link
Author

#31 (comment)

@Aga-C, I envisaged increasing the playback speed of, or skipping, silence.

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Feb 26, 2024
@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Feb 26, 2024

#31 (comment)

@inson1, the best I've thought of in that regard is that the threshold should be relative to the average volume of the file.

@Aga-C Aga-C removed the question Further information is requested label Feb 26, 2024
@naveensingh
Copy link
Member

Media3's ExoPlayer has built-in support for skipping silence. It'll require rewriting the playback-related code to use ExoPlayer. For the sake of simplicity, the threshold shouldn't be user-configurable.

@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app
Projects
None yet
Development

No branches or pull requests

4 participants