Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn or refuse to import invalid certificates #50

Open
SebastianOpriel opened this issue Feb 4, 2022 · 2 comments
Open

Warn or refuse to import invalid certificates #50

SebastianOpriel opened this issue Feb 4, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers plugin

Comments

@SebastianOpriel
Copy link

One is able to import a certificate which is no longer valid via API: PUT call on '/api/v1/config/clients/:client_id/keys'
see: https://github.com/Fraunhofer-AISEC/omejdn-server/blob/master/omejdn.rb#L753

To avoid mistakes and long debugging sessions, the API shall refuse to import such an invalid certificate or at least provide a warning. Maybe we can do something with another parameter like Boolean force_import

@schanzen
Copy link
Collaborator

schanzen commented Feb 4, 2022

Sounds reasonable. Expirations may bite us later: It could be that we want to provision clients ahead of time with certificates not yet valid ("Not Before" field).
So the question is: How to define "validity". Do we need to check against a trust store?
At least the "Not After" field should be checked, since we do that upon authorization.

@bellebaum
Copy link
Contributor

We probably also want to have a standardized error message format for the API, just like OAuth errors have a fixed format.
Currently, the Admin- and Selfservice APIs provide next to no error checking besides authorization.

@bellebaum bellebaum added enhancement New feature or request good first issue Good for newcomers labels Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers plugin
Projects
None yet
Development

No branches or pull requests

3 participants