Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies #21

Open
Akii opened this issue Jul 6, 2015 · 7 comments
Open

Dependencies #21

Akii opened this issue Jul 6, 2015 · 7 comments

Comments

@Akii
Copy link
Contributor

Akii commented Jul 6, 2015

nicolopignatelli/valueobjects has some requirements that just don't really make any sense like mathiasverraes/money (which is afaik, an example implementation for VOs).

Additionally the Enum thing is not supported by PHPStorm. I'd like deprecate that for simple constants. With that we would only have a dependency to guzzle. Then use rhumsaa/uuid directly for UUID generation.

Not saying that the valueobjects package is bad btw! Just a lot of unnecessary dependencies :)
If you guys agree I'd provide a PR soonish.

@dbellettini
Copy link
Member

@nicolopignatelli if you agree we might just copy as few classes as possible from valueobjects to this project moving to the right namespaces

@nicolopignatelli
Copy link
Collaborator

that, or just code the minimum needed to accomplish whatever we want here

@Akii
Copy link
Contributor Author

Akii commented Jul 19, 2015

thanks for looking into this :)

@dbellettini
Copy link
Member

did a couple of spike, but it's not that easy to do keeping the bar green, I will give another try next weekend

@dbellettini
Copy link
Member

sorry for postponing again

@dbellettini
Copy link
Member

done with dependency removal, php-enum stuff still to address, but I don't have time 😢 and I'll give priority to #23

@Akii
Copy link
Contributor Author

Akii commented Aug 21, 2015

Cool! thanks for your work :D #23 sounds nasty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants