Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The XMLTV output should validate using tv_validate_file #103

Closed
petterreinholdtsen opened this issue Nov 9, 2018 · 3 comments
Closed

The XMLTV output should validate using tv_validate_file #103

petterreinholdtsen opened this issue Nov 9, 2018 · 3 comments

Comments

@petterreinholdtsen
Copy link
Member

The tv_validate_file program from the xmltv-util Debian package (source http://xmltv.org/), claim the XMLTV file provided by frikanalen.no is invalid.

I test like this:

wget -O show.xml https://frikanalen.no/xmltv/2018/11/09
tv_validate_file show.xml

This is the start of the output:

The file is not valid according to the xmltv dtd:
 show.xml:2: validity error : Element channel content does not follow the DTD, expecting (display-name+ , icon* , url*), got (url display-name )
show.xml:12: validity error : Element programme content does not follow the DTD, expecting (title+ , sub-title* , desc* , credits? , date? , category* , keyword* , language? , orig-language? , length? , icon* , url* , country* , episode-num* , video? , audio? , previously-shown? , premiere? , last-chance? , new? , subtitles* , rating* , star-rating* , review*), got (title desc url length )
show.xml:12: validity error : Element programme does not carry attribute channel
show.xml:12: validity error : No declaration for attribute id of element programme
show.xml:12: validity error : No declaration for attribute end of element programme
show.xml:17: validity error : Element length does not carry attribute units
show.xml:17: validity error : No declaration for attribute unit of element length
show.xml:24: validity error : Element programme content does not follow the DTD, expecting (title+ , sub-title* , desc* , credits? , date? , category* , keyword* , language? , orig-language? , length? , icon* , url* , country* , episode-num* , video? , audio? , previously-shown? , premiere? , last-chance? , new? , subtitles* , rating* , star-rating* , review*), got (title desc url length )

Perhaps this is related to the fact that our schedule do not show up in the RiksTV EPG?
petterreinholdtsen added a commit to petterreinholdtsen/frikanalen that referenced this issue Nov 9, 2018
@petterreinholdtsen
Adjust XMLTV output to try to make it validate using tv_validate_file.
898ed26 
The tag ordering and some attributes had to be adjusted.  Note, this change
is not tested, as I lack a test setup for running the code.

This should fix issue Frikanalen#103.
@petterreinholdtsen petterreinholdtsen mentioned this issue Nov 9, 2018
Closed
@petterreinholdtsen
Copy link
Member Author

I started looking at this when discovering that the tvguide kodi add-on did not find any programs in our XMLTV source. It can perhaps be used to test if the XMLTV output is understandable.

@petterreinholdtsen
Copy link
Member Author

Note, I had to patch the tvguide add-on to work around twinther/script.tvguide#21 issue.

petterreinholdtsen added a commit to petterreinholdtsen/frikanalen that referenced this issue Nov 9, 2018
@petterreinholdtsen
Adjust XMLTV output to try to make it validate using tv_validate_file.
8151302 
The tag ordering and some attributes had to be adjusted.  Note, this change
is not tested, as I lack a test setup for running the code.

This should fix issue Frikanalen#103.
odinho pushed a commit that referenced this issue Nov 10, 2018
@petterreinholdtsen @odinho
XMLTV: Adjust output trying to validate using xmltv-utils
a52e796 
Specifically the command `tv_validate_file` from xmltv-utils.

The tag ordering and some attributes had to be adjusted.  Note, this change
is not tested, as I lack a test setup for running the code.

This should fix issue #103.
@petterreinholdtsen
Copy link
Member Author

I tested the tvguide kodi add-on with the updated XMLTV output from frikanalen.no, and now the program show up.

Unfortunately, the tvguide add-on can only accept one XMLTV URL, so I can only get one day to show up at the time. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petterreinholdtsen