Bug with childwindow patch on Wine 9.12

[lunarlattice0]

Hi,

I've identified a bug with the childwindow patch on Wine 9.12 that causes Roblox Studio to not function correctly:

as built here

The patch functions correctly on Wine 9.2, and Roblox Studio does not have any graphical issues in that version.

Please advise, thanks

[km9l]

I've identified a bug with the childwindow patch on Wine 9.12 that causes Roblox Studio to not function correctly: as built here

to clarify, this happens on roblox studio's vulkan renderer with proprietary nvidia drivers. the d3d11 engine (with or without dxvk) works worse. the person who tested this seems to have no issues with his amd gpu, but that gpu apparently works slow for him.

when using the vulkan renderer and nvidia drivers, the workspace editor of studio is broken until the studio window is resized. after the resize, the editor works but is positioned at 0,0:

after some investigation, the workspace editor being frozen until a resize might be a nvidia driver or roblox bug. this roblox print seems to be spammed until the resize:

2024-07-15T15:08:08.219Z,32.219639,07c4,6 [FLog::Graphics] VULKAN ERROR: vkAcquireNextImageKHR(device, windowData->swapChain, UINT64_MAX, acquireSemaphore, VK_NULL_HANDLE, &windowData->imageIndex) returned -1000001004 (VK_ERROR_OUT_OF_DATE_KHR)"

this warning is printed after the resize, i assume this part is a childwindow bug:

06a4:warn:vulkan:win32u_vkQueuePresentKHR Copying vulkan child window 0x1c010e rect (0,0)-(101,101)

full log of warn:vulkan prints attached.
warnvulkan.txt

i forgot to mention, these screenshots and logs are from a wine 9.13 build, with the same patch. the person who is testing the build said that flashing menus (visible in the OP) went away with the 9.13 build.
vinegarhq/wine-builds@8cd2a8c

The patch functions correctly on Wine 9.2, and Roblox Studio does not have any graphical issues in that version.

not for everyone 😅: vinegarhq/vinegar#423

[Artewar67]

I tried to make the patch work somehow and used https://gitlab.winehq.org/rbernon/wine and the "wip/vulkan-child-window" branch but I have no luck. I have interestingly much worse artifacts and maybe the new patch will work better for you.
childwindow-proton-mainline.txt
childwindow-proton.txt

Rename txt to patch!

[plaimbock]

It would help if you could mention any childwindow issues in this MR:
https://gitlab.winehq.org/wine/wine/-/merge_requests/5573

[km9l]

I tried to make the patch work somehow and used https://gitlab.winehq.org/rbernon/wine and the "wip/vulkan-child-window" branch but I have no luck. I have interestingly much worse artifacts and maybe the new patch will work better for you.

i tested it myself too, and i had intense flickering, wrong positioned menus and weird noise. for some reason my friend doesnt have that.
this new patch didnt really change anything

It would help if you could mention any childwindow issues in this MR

i will do. thanks.

[Artewar67]

It would help if you could mention any childwindow issues in this MR:
https://gitlab.winehq.org/wine/wine/-/merge_requests/5573

I tried to test it on a plain wine to make sure that it is a problem with the childwindow patch itself and yes it is a childwindow problem. So I left a comment with a description of the issues and a log file.

[km9l]

I tried to test it on a plain wine to make sure that it is a problem with the childwindow patch itself and yes it is a childwindow problem. So I left a comment with a description of the issues and a log file.

thanks a lot! btw, you tested it with dxvk which has more instabilities. the same is observable with the roblox vulkan engine though. (you can test that too by changing the renderer from studio settings) wined3d with d3d11 renderer works ok.

sorry, another edit: for some reason d3d11 was forced on his amd igpu with xorg.
edit: apparently the results below are from xorg and his amd igpu which always worked. (surprisingly)
real wayland results:

also, we have just tested the patch in the new wayland childwindow MR. my friend is reporting great results besides some menus and a button rendered offscreen (so they have intense flickering). even resizing menus work fine unlike xorg which is cool:

[sakx7]

I'm encountering the same problems. Is there a fix for it?

[km9l]

I'm encountering the same problems. Is there a fix for it?

not yet as far as i know

[Artewar67]

@lunarlattice0 @km9l
Today was in upstream wine was merged childwindow support and I can confirm that it works fully correctly with roblox studio but only with dxvk. Native vulkan has become completely broken for me in general

https://gitlab.winehq.org/wine/wine/-/merge_requests/6467

[Artewar67]

@Tk-Glitch I think we can close this issue

[Tk-Glitch]

Fixed upstream.