Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor Hover #202

Open
Ask-Sarthak-Goel opened this issue Oct 13, 2023 · 9 comments
Open

Cursor Hover #202

Ask-Sarthak-Goel opened this issue Oct 13, 2023 · 9 comments
Assignees

Comments

@Ask-Sarthak-Goel
Copy link

Description

I think it would be nice when hovering cursor over the icons/images under Batch section, the selected images get enlarged to signify what is being selected and even add a hyperlink when clicking on images.
Currently Images are not interactive at all, this feature may enhance Website experience and batch selection on HomePage.
image

@github-actions
Copy link

Hi 😄, thanks for creating your first contribution at Official-Website, do read and follow the Contribution Guidelines while contributing.

@monisanees270798
Copy link
Contributor

I have started working on this new feature.
Can I get assigned to this task?
So my work does not get interfered by others.
Thank You
@Ask-Sarthak-Goel @Vishal-raj-1 @ManishBisht777 @ManishBisht7

@Vishal-raj-1
Copy link
Member

@monisanees270798 sure, you can work this issue

@monisanees270798
Copy link
Contributor

monisanees270798 commented Oct 14, 2023

I have completed the task but I am facing a problem somewhere else Batches -> index.mdx.
I cannot seem to understand why changing just tracks.tsx (with "use client" and some additional code) is causing an error in Getting Started -> Introduction.
Any help would be helpful @Vishal-raj-1 @ManishBisht777
image
image

@Vishal-raj-1
Copy link
Member

Hey @monisanees270798 I am not able to understand what do you want to convey? Could you please share screenshot of code which you are not able to understand

@monisanees270798
Copy link
Contributor

monisanees270798 commented Oct 15, 2023

Hey @Vishal-raj-1
Thank you for reaching out. I identified the problem and managed to correct it (It was because I used "use client;" within tracks.tsx) causing client/server image declaration). Instead I performed a CSS to resolve it.
I will now commit and push it to my branch (https://github.com/monisanees270798/Official-Website/tree/cursorHover)
Please review it and let me know if I can procees with the PR.
Many thanks
@Vishal-raj-1
PS: I also performed an upstream pull to sync my fork with this repo

@Vishal-raj-1
Copy link
Member

@monisanees270798 You have to raise the PR. So that I review it

@monisanees270798
Copy link
Contributor

Please review and let me know your feedback on my PR.
Thank you.

@sridharrajaram
Copy link
Contributor

@Vishal-raj-1 @ManishBisht777 please mark this as closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants