feat: full blocks, bundling & compression, blob usage optimization & tracking #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmitter into feat/blob-logging
digorithm
reviewed
Sep 24, 2024
Comment on lines
+129
to
+140
| /// - **Exclusion of Stale Blocks:** If a block arrives with a height less than the current | ||
| /// height minus the `block_height_lookback`, it will be excluded from the bundling process. | ||
| /// | ||
| /// - **Bundling Behavior:** | ||
| /// - **Unbundled Blocks:** Blocks outside the lookback window will not be bundled. | ||
| /// - **Already Bundled Blocks:** If a block has already been bundled, its fragments will | ||
| /// not be sent to L1. | ||
| /// - **Failed Submissions:** If fragments of a bundled block were sent to L1 but failed, | ||
| /// they will not be retried. | ||
| /// | ||
| /// This approach effectively "gives up" on blocks that fall outside the defined window. | ||
| pub block_height_lookback: u32, |
There was a problem hiding this comment.
I'm still going over the code, but I have a question about this: Based on this bundling behavior, is there a chance that a block will be wrongfully excluded from bundling, thus not sending it to the L1?
This reverts commit 62d74c1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #116
closes: #124 (thanks to @hal3e for contributing)
description pending soon ™️ , doing a live presentation to the team at the moment...