Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gas price analysis: Investigate spikes in "Actual profit" when calculating with small da_finalization_period #2247

Open
rafal-ch opened this issue Sep 24, 2024 · 0 comments

Comments

@rafal-ch
Copy link
Contributor

rafal-ch commented Sep 24, 2024

When using the gas-price-analysis tool with low values for da_finalization_period (see: this PR) there are clearly visible spikes on the "Actual Profit".

This is not necessarily a bad thing, but it would be worth double checking what is the reason.

Examples:

cargo run -- -f ./chart.png --da-finalization-period 1 with-values 3232195 832882 predefined inscriptions_event_cleaned.csv -s 200

Image

cargo run -- -f ./chart.png --da-finalization-period 4 with-values 3232195 832882 predefined inscriptions_event_cleaned.csv -s 200

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant